[bgp] Fix overwrite in bgp conftest#7389
Merged
yaqiangz merged 1 commit intosonic-net:masterfrom Feb 7, 2023
Merged
Conversation
Blueve
approved these changes
Feb 3, 2023
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
pushed a commit
that referenced
this pull request
Feb 8, 2023
What is the motivation for this PR? In previous code, if the namespace of the portchannel is an empty string, DEFAULT_NAMESPACE set to conn["namespace"] will be overwrite by code below it. In M0 senario, if mx and m1 interfaces are selected, both conns are set to DEFAULT_NAMESPACE(Line 393), and then conn of M1 interface's namespace is overwrite to empty string in Line 398. Different namespace will lead test_bgp_update_timer failed. How did you do it? Verify portchannel namespace too. How did you verify/test it? Run test Signed-off-by: Yaqiang Zhu <[email protected]>
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
What is the motivation for this PR? In previous code, if the namespace of the portchannel is an empty string, DEFAULT_NAMESPACE set to conn["namespace"] will be overwrite by code below it. In M0 senario, if mx and m1 interfaces are selected, both conns are set to DEFAULT_NAMESPACE(Line 393), and then conn of M1 interface's namespace is overwrite to empty string in Line 398. Different namespace will lead test_bgp_update_timer failed. How did you do it? Verify portchannel namespace too. How did you verify/test it? Run test Signed-off-by: Yaqiang Zhu <[email protected]>
yaqiangz
added a commit
to yaqiangz/sonic-mgmt
that referenced
this pull request
Apr 9, 2023
What is the motivation for this PR? In previous code, if the namespace of the portchannel is an empty string, DEFAULT_NAMESPACE set to conn["namespace"] will be overwrite by code below it. In M0 senario, if mx and m1 interfaces are selected, both conns are set to DEFAULT_NAMESPACE(Line 393), and then conn of M1 interface's namespace is overwrite to empty string in Line 398. Different namespace will lead test_bgp_update_timer failed. How did you do it? Verify portchannel namespace too. How did you verify/test it? Run test Signed-off-by: Yaqiang Zhu <[email protected]>
6 tasks
yaqiangz
added a commit
that referenced
this pull request
Apr 10, 2023
What is the motivation for this PR? Manually cherry-pick and resolve conflicts of adding support for m0 to simulate both t0 and t1 in everflow and bgp test. #7389 #7618 #6900 How did you verify/test it? Run everflow and bgp test on m0/t0/t1 testbeds, no errors. Signed-off-by: Yaqiang Zhu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In previous code, if the namespace of the portchannel is an empty string, DEFAULT_NAMESPACE set to conn["namespace"] will be overwrite by code below it. In M0 senario, if mx and m1 interfaces are selected, both conns are set to DEFAULT_NAMESPACE(Line 393), and then conn of M1 interface's namespace is overwrite to empty string in Line 398. Different namespace will lead test_bgp_update_timer failed.
How did you do it?
Verify portchannel namespace too.
How did you verify/test it?
Run test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation