Fix test_advanced_reboot: re-add missing import; do not run garp/icmp-responder on single TOR#7188
Merged
vaibhavhd merged 2 commits intosonic-net:masterfrom Jan 6, 2023
Conversation
yxieca
approved these changes
Jan 6, 2023
Collaborator
|
How did these recent changes went in without triggering PR test failure? |
Contributor
Author
6 tasks
wangxin
pushed a commit
that referenced
this pull request
Apr 20, 2023
…-responder on single TOR (#7188) This PR fixes two recently introduced issues: Fix advanced reboot tests fail on non-dualtor testbeds #7146 caused by [advanced-reboot] IO path verification fixes for dualtor #6968 After merge of PR Fix pre-commit check errors in platform_tests/conftest.py #7049 , all testcases using get_advanced_reboot fixture are failing due to fixture 'get_advanced_reboot' not found How did you do it? To fix 7146, do not run GARP service and ICMP responder for non-dualtor advanced-reboot cases. I have not added a more simple skip for non-dualtor as these services are still needed for MOCK dualtor cases which run on single TOR testbeds. To fix 2, added a new import in the test scripts directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix recently introduced issues in test_advanced_reboot
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR fixes two recently introduced issues:
get_advanced_rebootfixture are failing due tofixture 'get_advanced_reboot' not foundHow did you do it?
To fix 7146, do not run GARP service and ICMP responder for non-dualtor advanced-reboot cases. I have not added a more simple skip for non-dualtor as these services are still needed for MOCK dualtor cases which run on single TOR testbeds.
To fix 2, added a new import in the test scripts directly.
How did you verify/test it?
Tested on single TOR and dual TOR devices, and failures are not seen anymore.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation