Fix pre-commit check errors in platform_tests/conftest.py#7049
Merged
msosyak merged 3 commits intosonic-net:masterfrom Dec 19, 2022
Merged
Fix pre-commit check errors in platform_tests/conftest.py#7049msosyak merged 3 commits intosonic-net:masterfrom
msosyak merged 3 commits intosonic-net:masterfrom
Conversation
bratashX
changed the title
Signed-off-by: Petro Bratash <[email protected]>
Signed-off-by: Petro Bratash <[email protected]>
bratashX
force-pushed
the
fix_pre-commit-check
branch
12 times, most recently
from
e834005 to
185b84d
Compare
Signed-off-by: Petro Bratash <[email protected]>
xwjiang-ms
approved these changes
Dec 19, 2022
msosyak
approved these changes
Dec 19, 2022
6 tasks
This was referenced Jan 5, 2023
Merged
vaibhavhd
added a commit
that referenced
this pull request
Jan 6, 2023
…-responder on single TOR (#7188) This PR fixes two recently introduced issues: Fix advanced reboot tests fail on non-dualtor testbeds #7146 caused by [advanced-reboot] IO path verification fixes for dualtor #6968 After merge of PR Fix pre-commit check errors in platform_tests/conftest.py #7049 , all testcases using get_advanced_reboot fixture are failing due to fixture 'get_advanced_reboot' not found How did you do it? To fix 7146, do not run GARP service and ICMP responder for non-dualtor advanced-reboot cases. I have not added a more simple skip for non-dualtor as these services are still needed for MOCK dualtor cases which run on single TOR testbeds. To fix 2, added a new import in the test scripts directly.
wangxin
pushed a commit
that referenced
this pull request
Apr 20, 2023
…-responder on single TOR (#7188) This PR fixes two recently introduced issues: Fix advanced reboot tests fail on non-dualtor testbeds #7146 caused by [advanced-reboot] IO path verification fixes for dualtor #6968 After merge of PR Fix pre-commit check errors in platform_tests/conftest.py #7049 , all testcases using get_advanced_reboot fixture are failing due to fixture 'get_advanced_reboot' not found How did you do it? To fix 7146, do not run GARP service and ICMP responder for non-dualtor advanced-reboot cases. I have not added a more simple skip for non-dualtor as these services are still needed for MOCK dualtor cases which run on single TOR testbeds. To fix 2, added a new import in the test scripts directly.
6 tasks
vaibhavhd
added a commit
that referenced
this pull request
Apr 26, 2023
#8108) The test_advanced_reboot fails on master branch when it fails to reboot the device, and fails w/ incorrect error: DUT hasn't shutdown in 300 seconds. In reality the device is not rebooted at all as the test library crashes while doing so. The error is apparent when traceback is enabled in the code. This PR fixes the error (introduced after change in #7817), added traceback for better debug support. Also, this fixes a part where reboot timing data is not printed entirely as the logs path can't be parsed due to a change in #7049 Tested on physical testbed
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
sonic-net#8108) The test_advanced_reboot fails on master branch when it fails to reboot the device, and fails w/ incorrect error: DUT hasn't shutdown in 300 seconds. In reality the device is not rebooted at all as the test library crashes while doing so. The error is apparent when traceback is enabled in the code. This PR fixes the error (introduced after change in sonic-net#7817), added traceback for better debug support. Also, this fixes a part where reboot timing data is not printed entirely as the logs path can't be parsed due to a change in sonic-net#7049 Tested on physical testbed
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
sonic-net#8108) The test_advanced_reboot fails on master branch when it fails to reboot the device, and fails w/ incorrect error: DUT hasn't shutdown in 300 seconds. In reality the device is not rebooted at all as the test library crashes while doing so. The error is apparent when traceback is enabled in the code. This PR fixes the error (introduced after change in sonic-net#7817), added traceback for better debug support. Also, this fixes a part where reboot timing data is not printed entirely as the logs path can't be parsed due to a change in sonic-net#7049 Tested on physical testbed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petro Bratash [email protected]
Description of PR
Fix the next pre-commit check error in
tests/platform_tests/conftest.py: