Remove MGMT_INTERFACE from ip2me block rule list#7092
Remove MGMT_INTERFACE from ip2me block rule list#7092SuvarnaMeenakshi merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
tests/cacl/test_cacl_application.py
Outdated
| "PORTCHANNEL_INTERFACE", | ||
| "INTERFACE" | ||
| ] | ||
| incl_mgmt_if_branch = ['201911', '202012', '202111', '202205'] |
There was a problem hiding this comment.
afaik, the caclmgrd changes were not backported to 201911, 202012 and previous branches. Is this only required for master?
There was a problem hiding this comment.
the caclmgrd changes are not backported to 201911, 202012 or 202205 branches https://github.com/sonic-net/sonic-buildimage/blob/202205/src/sonic-host-services/scripts/caclmgrd#L246
So will need in master or in future branches based off master.
so we include mgmt_interface only for older branches.
There was a problem hiding this comment.
yes, but we've sonic-mgmt branch for 201911, 202012 which still has MGMT_INTERFACE
There was a problem hiding this comment.
Right, so we dont need this check here, should we assume that everyone will run this test case with the right sonic-mgmt branch corresponding to the image?
There was a problem hiding this comment.
Yes, because I don't think we can run master sonic-mgmt on older branches anymore as the tests have diverged
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
…sonic-net#7374) What is the motivation for this PR? Issue sonic-net#12464 was fixed in sonic-net#7092. How did you do it? Remove skip condition for test_cacl_application.py How did you verify/test it? Run test_cacl_application.py against master image. Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
2 participants
Signed-off-by: Suvarna Meenakshi sumeenak@microsoft.com
Description of PR
Summary:
Fixes #12464
Type of change
Back port request
Approach
What is the motivation for this PR?
Provides fix for sonic-net/sonic-buildimage#12464
MGMT_INTERFACE was removed from default ip2me block rules in PR sonic-net/sonic-host-services#6
This PR is to modify the test case according to the change in caclmgrd
How did you do it?
Remove MGMT_INTERFACE when generating ip2me block rule list.
How did you verify/test it?
Ran test on multi-asic vs DUT, without skipping this test:
..
cacl/test_cacl_application.py::test_cacl_application_nondualtor[vlab-08-1]
PASSED [ 70%]
cacl/test_cacl_application.py::test_cacl_application_dualtor[active_tor-vlab-08-1] SKIPPED [ 80%]
cacl/test_cacl_application.py::test_cacl_application_dualtor[standby_tor-vlab-08-1] SKIPPED [ 90%]
cacl/test_cacl_application.py::test_multiasic_cacl_application[vlab-08-1]
PASSED
SKIPPED [4] cacl/test_cacl_application.py: test_cacl_application_dualtor is only supported on dualtor topology
SKIPPED [1] cacl/test_cacl_application.py: caclmgrd may crash after loading scale ipv4 cacl rules.
SKIPPED [1] cacl/test_cacl_application.py: caclmgrd may crash after loading scale ipv6 cacl rules.
============================================================================================================ 4 passed, 6 skipped in 769.78 seconds =============================================================================================================
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation