[action] [PR:12390] Add topology mark in the module already in PR test#12464
Merged
mssonicbld merged 1 commit intosonic-net:202311from Apr 16, 2024
Merged
[action] [PR:12390] Add topology mark in the module already in PR test#12464mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld merged 1 commit intosonic-net:202311from
Conversation
What is the motivation for this PR? In our pytest, it's mandatory to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.
8 tasks
Collaborator
Author
|
Original PR: #12390 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In our pytest, it's crucial to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In our pytest, it's crucial to have proper markers for different test topologies to ensure that tests are run in the correct testbeds. It seems that some modules, despite having passed the PR tests, lack the necessary topology markers. In this PR, we add the missing markers, which will enhance the clarity and efficiency of the testing process and ensure that each module is tested on the appropriate testbeds.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation