Skip to content

Changed validation that device was rebooted in case of reboot #7064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ppikh wants to merge 1 commit into from
Closed

Changed validation that device was rebooted in case of reboot #7064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/common/reboot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ def reboot(duthost, localhost, reboot_type='cold', delay=10,
except KeyError:
raise ValueError('invalid reboot type: "{} for {}"'.format(reboot_type, hostname))

reboot_res, dut_datetime = perform_reboot(duthost, pool, reboot_command, reboot_helper, reboot_kwargs, reboot_type)
uptime_before_reboot = duthost.get_uptime()
reboot_res, _ = perform_reboot(duthost, pool, reboot_command, reboot_helper, reboot_kwargs, reboot_type)

wait_for_shutdown(duthost, localhost, delay, timeout, reboot_res)
# if wait_for_ssh flag is False, do not wait for dut to boot up
Expand All @@ -247,10 +248,11 @@ def reboot(duthost, localhost, reboot_type='cold', delay=10,
DUT_ACTIVE.set()
logger.info('{} reboot finished on {}'.format(reboot_type, hostname))
pool.terminate()
dut_uptime = duthost.get_up_time()
logger.info('DUT {} up since {}'.format(hostname, dut_uptime))
assert float(dut_uptime.strftime("%s")) > float(dut_datetime.strftime("%s")), "Device {} did not reboot". \
format(hostname)
uptime_after_reboot = duthost.get_uptime()
logger.info('DUT {} uptime before reboot: {} minutes, uptime after reboot: {} minutes'.format(hostname,
uptime_before_reboot,
uptime_after_reboot))
assert uptime_before_reboot > uptime_after_reboot, "Device {} did not reboot".format(hostname)


def get_reboot_cause(dut):
Expand Down