Skip to content

Updated XFAIL conditions for qos tests to include Nokia HWSKUs #6931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmittal-msft wants to merge 1 commit into from
Closed

Updated XFAIL conditions for qos tests to include Nokia HWSKUs #6931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,13 +723,13 @@ qos/test_qos_sai.py::TestQosSai::testQosSaiHeadroomPoolSize[None]:
skip:
reason: "Headroom pool size not supported."
conditions:
- "hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32'] and asic_type not in ['mellanox']"
- "hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32', 'Nokia-IXR7250E-36x100G', 'Nokia-IXR7250E-36x400G'] and asic_type not in ['mellanox']"
Copy link
Copy Markdown
Contributor

@sanmalho-git sanmalho-git Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmittal-msft - this test is passing for us, except for the in_discard stats. Why are we adding 'skip' for this test on Nokia.


qos/test_qos_sai.py::TestQosSai::testQosSaiHeadroomPoolWatermark:
xfail:
reason: "Headroom pool size not supported."
conditions:
- "platform in ['x86_64-arista_7050cx3_32s'] or hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32']"
- "platform in ['x86_64-arista_7050cx3_32s'] or hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32', 'Nokia-IXR7250E-36x100G', 'Nokia-IXR7250E-36x400G']"
Copy link
Copy Markdown
Contributor

@sanmalho-git sanmalho-git Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed today, we are going to skip this test instead of marking it as xfail.


qos/test_qos_sai.py::TestQosSai::testQosSaiPGDrop:
skip:
Expand Down