Updated XFAIL conditions for qos tests to include Nokia HWSKUs#6931
Closed
vmittal-msft wants to merge 1 commit intosonic-net:masterfrom
Closed
Updated XFAIL conditions for qos tests to include Nokia HWSKUs#6931vmittal-msft wants to merge 1 commit intosonic-net:masterfrom
vmittal-msft wants to merge 1 commit intosonic-net:masterfrom
Conversation
| reason: "Headroom pool size not supported." | ||
| conditions: | ||
| - "hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32'] and asic_type not in ['mellanox']" | ||
| - "hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32', 'Nokia-IXR7250E-36x100G', 'Nokia-IXR7250E-36x400G'] and asic_type not in ['mellanox']" |
Contributor
There was a problem hiding this comment.
@vmittal-msft - this test is passing for us, except for the in_discard stats. Why are we adding 'skip' for this test on Nokia.
| reason: "Headroom pool size not supported." | ||
| conditions: | ||
| - "platform in ['x86_64-arista_7050cx3_32s'] or hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32']" | ||
| - "platform in ['x86_64-arista_7050cx3_32s'] or hwsku not in ['Arista-7060CX-32S-C32', 'Celestica-DX010-C32', 'Arista-7260CX3-D108C8', 'Force10-S6100', 'Arista-7260CX3-Q64', 'Arista-7050CX3-32S-C32', 'Nokia-IXR7250E-36x100G', 'Nokia-IXR7250E-36x400G']" |
Contributor
There was a problem hiding this comment.
As discussed today, we are going to skip this test instead of marking it as xfail.
Contributor
Author
|
Closing this PR as changes are handled as part of other PR #6946 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Updated XFAIL conditions for qos tests to include Nokia HWSKUs
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To update XFAIL conditions for qos tests to include Nokia HWSKUs
How did you do it?
Updated test_mark_condition file to add the check.
How did you verify/test it?
On Nokia testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation