[202205] Fixing auto_techsupport#6882
Merged
Blueve merged 2 commits intosonic-net:202205from Nov 29, 2022
Merged
Conversation
Previously parsing of the auto-testsupport CLI commands for 202205 were using 202111 as the base, which had a number of changes from the default to handle older CLI commands. This change allows 202205 to parse the newer format that is used in 202205
xwjiang-ms
approved these changes
Nov 24, 2022
Contributor
There was a problem hiding this comment.
@davidm-arista LGTM, could you also cherry-pick this file to master branch? Suggest go master first in future.
Collaborator
|
Hi @davidm-arista, thanks for providing the fix! Can you submit the fix to master branch and then we can backport to 202205 |
Collaborator
Author
|
This patch doesn't apply to master. The file is quite different in master. |
Collaborator
@davidm-arista Do we have same issue in master branch image now? |
Collaborator
Author
|
I haven't looked at master test results, but the code is different enough, that I doubt the same issue exists. We can look later once the 202205 results are looking good. |
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Jul 27, 2023
…ic-mgmt into internal-202205 Fix merge conflicts. - Fix verify_no_packet_any call in fib_test (sonic-net#6461) - Fix the test case test_TSA failure when check the routes on the eos host (sonic-net#6483) - Use conditional mark to skip testcase instead of required_mocked_dualtor (sonic-net#6766) - [tagged_arp] fix issue 'fixture ports_list not found' (sonic-net#6773) - [QoS] fixes after moving to python3 (sonic-net#6786) - update parse funciton for image url (sonic-net#6848) - Fix typo in get_queue_counter (sonic-net#6852) - Revert "Fix loganalyzer.py UnicodeDecodeError (sonic-net#6524)" (sonic-net#6858) - Enhancing core_dump_and_config_check to be multi-asic aware (sonic-net#6527) - Adding support for calculating balancing in multi-lc/multi-asic case (Test_fib.py) (sonic-net#6391) - Support different RC in case of pre or post sanity check failed (sonic-net#6860) - Update getbuild.py to support pass an empty access_token - [202205] Fixing auto_techsupport (sonic-net#6882) - Merge branch 'azure-202205' into dev/yaqiangzhu/202205_manually_merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sonic-mgmt bug Fix: Fix regex parser for show auto-techsupport global command