Skip to content

Fix typo in get_queue_counter#6852

Merged
bingwang-ms merged 1 commit intomasterfrom
fix_typo_in_cmd
Nov 18, 2022
Merged

Fix typo in get_queue_counter#6852
bingwang-ms merged 1 commit intomasterfrom
fix_typo_in_cmd

Conversation

@bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
This PR is to fix a typo in get_queue_counter defined in tunnel_qos_remap_base.py.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

This PR is to fix a typo in get_queue_counter defined in tunnel_qos_remap_base.py.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@azure-pipelines
Copy link

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/qos/tunnel_qos_remap_base.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/tunnel_qos_remap_base.py:14:1: F401 'tests.common.dualtor.mux_simulator_control.mux_server_url' imported but unused
tests/qos/tunnel_qos_remap_base.py:14:1: F401 'tests.common.dualtor.mux_simulator_control.toggle_all_simulator_ports' imported but unused
tests/qos/tunnel_qos_remap_base.py:15:1: F401 'tests.common.fixtures.ptfhost_utils.ptf_portmap_file_module' imported but unused
tests/qos/tunnel_qos_remap_base.py:19:1: E302 expected 2 blank lines, found 1
tests/qos/tunnel_qos_remap_base.py:19:121: E501 line too long (136 > 120 characters)
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request fixes 1 alert when merging aaafa0b into 795d774 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@bingwang-ms bingwang-ms merged commit 5fd3a68 into master Nov 18, 2022
wangxin pushed a commit that referenced this pull request Nov 23, 2022
@wangxin wangxin deleted the fix_typo_in_cmd branch January 9, 2023 00:04
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request Jul 27, 2023
…ic-mgmt into internal-202205

Fix merge conflicts.

- Fix verify_no_packet_any call in fib_test (sonic-net#6461)
- Fix the test case test_TSA failure when check the routes on the eos host (sonic-net#6483)
- Use conditional mark to skip testcase instead of required_mocked_dualtor (sonic-net#6766)
- [tagged_arp] fix issue 'fixture ports_list not found' (sonic-net#6773)
- [QoS] fixes after moving to python3 (sonic-net#6786)
- update parse funciton for image url (sonic-net#6848)
- Fix typo in get_queue_counter (sonic-net#6852)
- Revert "Fix loganalyzer.py UnicodeDecodeError (sonic-net#6524)" (sonic-net#6858)
- Enhancing core_dump_and_config_check to be multi-asic aware (sonic-net#6527)
- Adding support for calculating balancing in multi-lc/multi-asic case (Test_fib.py) (sonic-net#6391)
- Support different RC in case of pre or post sanity check failed (sonic-net#6860)
- Update getbuild.py to support pass an empty access_token
- [202205] Fixing auto_techsupport (sonic-net#6882)
- Merge branch 'azure-202205' into dev/yaqiangzhu/202205_manually_merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants