Skip to content

Revert T2 everflow#6632

Merged
yxieca merged 3 commits intosonic-net:masterfrom
StormLiangMS:revert_everflow
Oct 26, 2022
Merged

Revert T2 everflow#6632
yxieca merged 3 commits intosonic-net:masterfrom
StormLiangMS:revert_everflow

Conversation

@StormLiangMS
Copy link
Collaborator

@StormLiangMS StormLiangMS commented Oct 26, 2022

Description of PR

Summary:
After this PR #6225, many T0/T1 ever flow cases would be failed.
After two fixes,
#6609
#6561
it still fails many T0/T1 everflow cases.

Revert T2 everflow, pls pass T0/T1 testcases before commit. @tcusto

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@azure-pipelines
Copy link

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/everflow_test_utilities.py
Fixing tests/everflow/test_everflow_per_interface.py
Fixing tests/everflow/test_everflow_testbed.py

fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/test_everflow_per_interface.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2022

This pull request introduces 1 alert when merging a976422 into 19c3521 - view on LGTM.com

new alerts:

  • 1 for Unused import

@yxieca yxieca merged commit 1422b9b into sonic-net:master Oct 26, 2022
yxieca pushed a commit that referenced this pull request Oct 26, 2022
* Revert "[everflow] address testbed setup type checking issue (#6609)"

This reverts commit b55fe7f.

* Revert "everflow test case fix (#6561)"

This reverts commit b497aa0.

* Revert "Everflow T2 topo support and ipv6 egress tests (#6225)"

This reverts commit c3f0980.
allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this pull request Oct 28, 2022
* Revert "[everflow] address testbed setup type checking issue (sonic-net#6609)"

This reverts commit b55fe7f.

* Revert "everflow test case fix (sonic-net#6561)"

This reverts commit b497aa0.

* Revert "Everflow T2 topo support and ipv6 egress tests (sonic-net#6225)"

This reverts commit c3f0980.
judyjoseph added a commit to judyjoseph/sonic-mgmt that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants