Conversation
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
What is the motivation for this PR? This PR #6225 introduced one issue for T0/T1. The pytest will be crashed when running everflow test. The reason is because the implementation of one fixture, setup_recycle_port, which include the yield but not run into the yield for non t2 case, which will hit one known issue of pytest, which is fixed in newer version of pytest but not in what we are using now. pytest-dev/pytest#7061 How did you do it? Change the condition to make sure the yield would be executed How did you verify/test it? Run everflow test. Any platform specific information? Supported testbed topology if it's a new test case?
This reverts commit b497aa0.
This reverts commit b497aa0.
What is the motivation for this PR? This PR sonic-net#6225 introduced one issue for T0/T1. The pytest will be crashed when running everflow test. The reason is because the implementation of one fixture, setup_recycle_port, which include the yield but not run into the yield for non t2 case, which will hit one known issue of pytest, which is fixed in newer version of pytest but not in what we are using now. pytest-dev/pytest#7061 How did you do it? Change the condition to make sure the yield would be executed How did you verify/test it? Run everflow test. Any platform specific information? Supported testbed topology if it's a new test case?
* Revert "[everflow] address testbed setup type checking issue (sonic-net#6609)" This reverts commit b55fe7f. * Revert "everflow test case fix (sonic-net#6561)" This reverts commit b497aa0. * Revert "Everflow T2 topo support and ipv6 egress tests (sonic-net#6225)" This reverts commit c3f0980.
Description of PR
Summary:
This PR #6225 introduced one issue for T0/T1. The pytest will be crashed when running everflow test.
The reason is because the implementation of one fixture, setup_recycle_port, which include the yield but not run into the yield for non t2 case, which will hit one known issue of pytest, which is fixed in newer version of pytest but not in what we are using now.
pytest-dev/pytest#7061
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR #6225 introduced one issue for T0/T1. The pytest will be crashed when running everflow test.
The reason is because the implementation of one fixture, setup_recycle_port, which include the yield but not run into the yield for non t2 case, which will hit one known issue of pytest, which is fixed in newer version of pytest but not in what we are using now.
pytest-dev/pytest#7061
How did you do it?
Change the condition to make sure the yield would be executed
How did you verify/test it?
Run everflow test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation