[pfcwd]: add wait time to stablize the test#582
Merged
sihuihan88 merged 1 commit intosonic-net:masterfrom Apr 20, 2018
Merged
Conversation
Signed-off-by: Sihui Han <[email protected]>
stcheng
approved these changes
Apr 20, 2018
stepanblyschak
pushed a commit
to stepanblyschak/sonic-mgmt
that referenced
this pull request
Jul 4, 2018
Signed-off-by: Sihui Han <[email protected]>
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR is to improve [ansible/library/announce_routes.py](https://github.com/sonic-net/sonic-mgmt/compare/master...bingwang-ms:fix_announce_route_for_dt2?expand=1#diff-68b518f15cfb2d75f404b5d982cd1b23244d0775494df25b73f029842c384ec0) to support scenario when the number of VMs is not exactly divisible by `GROUP_SIZE`. Before this change: The last group doesn't have route advertised from exabgp. After this change: All groups have routes from exabgp. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? This PR is to improve ansible/library/announce_routes.py for DT2. #### How did you do it? Use `ceil` to get the correct number of groups. #### How did you verify/test it? The change is verified by running `announce_routes` on a physical testbed. #### Any platform specific information? No. #### Supported testbed topology if it's a new test case? Not a new test. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities fe2c656..afaedb7: > Revert "[FastReboot]: Send SIGINT to all teamd before stop (sonic-net#633)" (sonic-net#650) > Fixed config Asym PFC CLI. (sonic-net#632) > [config] Do no stop or restart dependent services (sonic-net#582) Signed-off-by: Ying Xie <[email protected]>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han [email protected]
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation