[hwsku] add platform/hwsku support in deploy_mg flow#3469
Open
dmytroxshevchuk wants to merge 1 commit intosonic-net:masterfrom
Open
[hwsku] add platform/hwsku support in deploy_mg flow#3469dmytroxshevchuk wants to merge 1 commit intosonic-net:masterfrom
dmytroxshevchuk wants to merge 1 commit intosonic-net:masterfrom
Conversation
3 tasks
Collaborator
|
@dmytroxshevchuk Can you solve the merge conflict? Is this PR still up-to-date with all the platform.json and hwsku.json updates? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
After transition from port_config.ini to platform.json, hwsku.json, we can`t fully deprecate and remove port_config.ini cause of port_mgmt/ansible use port_config.ini for generate minigraph. So currently we have configuration(platform.json, hwsku.json) using by sonic for configure ports and configuration(port_config.ini) using by sonic_mgmt for generate minigraph. So changes in platform.json and hwsku.json will not affect minigraph because of port_config.ini so we have configuration mismatch.
PR add functionality to sonic_mgmt for parse platform.json and hwsku.json and use this configuration for generation minigraph.
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
How did you do it?
Add functionality for parsing platform.json, hwsku.json and use this configuration for generate minigraph.
How did you verify/test it?
Compare generated minigraph/config_db configurations with platform.json, hwsku.json.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation