Skip to content

[hwsku] add platform/hwsku support in deploy_mg flow#3469

Open
dmytroxshevchuk wants to merge 1 commit intosonic-net:masterfrom
dmytroxshevchuk:platform_hwsku_support
Open

[hwsku] add platform/hwsku support in deploy_mg flow#3469
dmytroxshevchuk wants to merge 1 commit intosonic-net:masterfrom
dmytroxshevchuk:platform_hwsku_support

Conversation

@dmytroxshevchuk
Copy link
Contributor

@dmytroxshevchuk dmytroxshevchuk commented May 12, 2021

Description of PR

After transition from port_config.ini to platform.json, hwsku.json, we can`t fully deprecate and remove port_config.ini cause of port_mgmt/ansible use port_config.ini for generate minigraph. So currently we have configuration(platform.json, hwsku.json) using by sonic for configure ports and configuration(port_config.ini) using by sonic_mgmt for generate minigraph. So changes in platform.json and hwsku.json will not affect minigraph because of port_config.ini so we have configuration mismatch.
PR add functionality to sonic_mgmt for parse platform.json and hwsku.json and use this configuration for generation minigraph.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

  • fully deprecate and remove port_config.ini
  • avoid mismatch configurations between port_config.ini and platform.json, hwsku.json

How did you do it?

Add functionality for parsing platform.json, hwsku.json and use this configuration for generate minigraph.

How did you verify/test it?

Compare generated minigraph/config_db configurations with platform.json, hwsku.json.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@dmytroxshevchuk dmytroxshevchuk requested a review from a team as a code owner May 12, 2021 06:58
@dmytroxshevchuk dmytroxshevchuk changed the title Add platform/hwsku support in deploy_mg flow [hwsku] add platform/hwsku support in deploy_mg flow May 12, 2021
@yxieca
Copy link
Collaborator

yxieca commented Sep 9, 2021

@dmytroxshevchuk Can you solve the merge conflict? Is this PR still up-to-date with all the platform.json and hwsku.json updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants