[Sub-Port-Interfaces]Remove default acl tables before testing subinterfaces based on portchannels#5730
Closed
congh-nvidia wants to merge 1 commit intosonic-net:masterfrom
Closed
Conversation
…hannels In sub interfaces test, the portchannel cases add ethernet ports to portchannels, but on some testbeds, the selected ports are already in the default acl tables, so they can not be added to a port channel. Remove the default acl tables before the port channel cases, and the acl tables will be added back automatically by config reload in single test case and test suite teardowns.
congh-nvidia
changed the title
nhe-NV
approved these changes
May 30, 2022
Contributor
|
Hi @congh-nvidia. I've already added those changes in #5543. Please take a look. Thanks! |
Contributor
Author
|
Hi @OleksandrKozodoi, didn't see your PR before, I'm closing this PR then, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In sub interfaces test, the portchannel cases add ethernet ports to portchannels.
But on some testbeds, the selected ports are already in some default acl tables. In SONiC, ports in acl tables can not be used as portchannel members. So the case will fail.
To fix this, need to remove default acl tables before running the portchannel cases.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the portchannel cases to run on testbeds with default acl tables.
How did you do it?
The ethernet ports are selected and added to portchannels in fixture define_sub_ports_configuration, so add logic to remove the default acl tables in this fixture, before the ports are added.
The removal action won't affect testbeds without default acl tables.
The acl tables will be added back automatically by config reload in single test case and test suite teardowns.
How did you verify/test it?
Verified on t0 and t1 testbeds, all cases passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation