Added function for removing ACL table in sub-ports TC

[OleksandrKozodoi]

Signed-off-by: Oleksandr Kozodoi [email protected]

Description of PR

Summary:
#2165 PR of sonic-swss repo caused errors in sub-port interfaces on LAG TC. Before moving ports to LAG, user should disable active ACL binding. So was added approach for unbinding those ports from ACL tables.

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911
• 202012

Approach

What is the motivation for this PR?

Update sub_port_interfaces TC according to changes from #2165 PR of sonic-swss

How did you do it?

Added function for removing ACL table when ingress/egress ACL binding is configured on LAG members.

How did you verify/test it?

PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_valid_vlan[port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_invalid_vlan[port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_admin_status_down_disables_forwarding[port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_max_numbers_of_sub_ports[port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_mtu_inherited_from_parent_port[port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_vlan_config_impact[port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[same-port_in_lag-TCP-UDP-ICMP]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[different-port_in_lag-TCP-UDP-ICMP]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[svi-port_in_lag-TCP-UDP-ICMP]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[l3-port_in_lag-TCP-UDP-ICMP]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[same-port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[different-port_in_lag]
PASSED sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_balancing_sub_ports[port_in_lag]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[wangxin]

Does this configuration change need to be restored after testing is done?

[OleksandrKozodoi]

Hi @wangxin. This configuration is restored per test case:
https://github.com/Azure/sonic-mgmt/blob/master/tests/sub_port_interfaces/conftest.py#L537
Also, there is reload of the configuration after the test suite:
https://github.com/Azure/sonic-mgmt/blob/master/tests/sub_port_interfaces/conftest.py#L568-L577

[SavchukRomanLv]

@wangxin could you please take a look? @OleksandrKozodoi left comments

[OleksandrKozodoi]

@wangxin Can this be merged? Thank you in advance.

[ZhaohuiS]

LGTM