[MASIC] disable thermalctld when running test_fan_drawer_fans.py#5529
Merged
wenyiz2021 merged 9 commits intosonic-net:masterfrom Apr 22, 2022
wenyiz2021:master
Merged
[MASIC] disable thermalctld when running test_fan_drawer_fans.py#5529wenyiz2021 merged 9 commits intosonic-net:masterfrom wenyiz2021:master
wenyiz2021 merged 9 commits intosonic-net:masterfrom
wenyiz2021:master
Conversation
Update same changes in master branch from PR: (#5453)
Disable thermalctld when running test_fan_drawer_fans.py
Contributor
Author
|
Checks are failing at known macsec issue which was fixed by sonic-net/sonic-buildimage#10618. |
sujinmkang
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
When thermatlctld is on and tries to control/adjust fan speed/LEDs continuously, fan related tests will be impacted and may hit the restriction set from thermal_policy.json, and cause dut unreachable.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
./run_tests.sh -i '../ansible/str,../ansible/veos' -n {multi-asic} -u -e "--disable_loganalyzer --skip_sanity" -c platform_tests/api/test_fan_drawer_fans.py
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_name[str-n3164-acs-2] PASSED [ 7%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_presence[str-n3164-acs-2] PASSED [ 15%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_model[str-n3164-acs-2] PASSED [ 23%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_serial[str-n3164-acs-2] PASSED [ 30%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_status[str-n3164-acs-2] PASSED [ 38%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_position_in_parent[str-n3164-acs-2] PASSED [ 46%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_is_replaceable[str-n3164-acs-2] PASSED [ 53%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_speed[str-n3164-acs-2] PASSED [ 61%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_direction[str-n3164-acs-2] PASSED [ 69%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_fans_target_speed[str-n3164-acs-2] PASSED [ 76%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_get_fans_speed_tolerance[str-n3164-acs-2] PASSED [ 84%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_speed[str-n3164-acs-2] PASSED [ 92%]
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_led[str-n3164-acs-2] PASSED [100%]
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation