Update test_po_cleanup.py

[wenyiz2021]

Description of PR

For a multi-asic device, restart of swss and teamd is done per asic, noticed that for a 6-asic device, asic3 and asic4 are experiencing more time during restart. Also, interfaces and bgp neighbors need more minutes to come back. Execute a config_reload at the end of test_po_cleanup helps to bring back processes in a safe manner.
duthost.asic_instance(enum_asic_index).start_service("swss")
assert wait_until(300, 20, 0, duthost.critical_services_fully_started),\

      "Not all critical services are fully started"

E AssertionError: Not all critical services are fully started
duthost =
duthosts = []
enum_asic_index = 3
enum_rand_one_per_hwsku_frontend_hostname = 'xxx'
tbinfo = {'auto_recover': 'True', 'comment': 'Arvind', 'conf-name': 'xxx', 'duts': ['xxx'], ...}
[pc/test_po_cleanup.py:66: AssertionError]

1. Execute an "config_reload" at the end of test_po_cleanup, to start up not only all critical services, but also wait for all port, interfaces, bgp neighbors to come up.
2. Call duthost.stop_service("swss") directly from duthost, instead of passing each asics inside the test_po_cleanup. to avoid execution sequence of test_po_cleanup[asic0], test_po_cleanup_after_reload[duthost], test_po_cleanup[asic1].

Summary:
Fixes # (issue)
#5294
#4887

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• [ X] Test case(new/improvement)

Back port request

• [X ] 201911
• 202012

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

pc/test_po_cleanup.py::test_po_cleanup[str-masic-acs-2] PASSED [100%]

---------------------------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt-int/tests/logs/tr.xml ----------------------------------------------------------------------------------------------
=============================================================================================================== 1 passed in 489.35 seconds ================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[wenyiz2021]

Same issue as: #5294

[wenyiz2021]

pc/test_po_cleanup.py::test_po_cleanup[str-multi-asic-acs-2-0] PASSED [ 14%]
pc/test_po_cleanup.py::test_po_cleanup_after_reload[str-multi-asic-acs-2] PASSED [ 28%]
pc/test_po_cleanup.py::test_po_cleanup[str-multi-asic-acs-2-1] PASSED [ 42%]
pc/test_po_cleanup.py::test_po_cleanup[str-multi-asic-acs-2-2] PASSED [ 57%]
pc/test_po_cleanup.py::test_po_cleanup[str-multi-asic-acs-2-3] PASSED [ 71%]
pc/test_po_cleanup.py::test_po_cleanup[str-multi-asic-acs-2-4] PASSED [ 85%]
pc/test_po_cleanup.py::test_po_cleanup[str-multi-asic-acs-2-5] PASSED [100%]

============================================================================================================== 7 passed in 1630.24 seconds

[wenyiz2021]

New change commited:
pc/test_po_cleanup.py::test_po_cleanup[str-masic-acs-2] PASSED [100%]

---------------------------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt-int/tests/logs/tr.xml ----------------------------------------------------------------------------------------------
=============================================================================================================== 1 passed in 489.35 seconds ================================================================================================================

[wenyiz2021]

New change description:

1. Execute an "config_reload" at the end of test_po_cleanup, to start up not only all critical services, but also wait for all port, interfaces, bgp neighbors to come up.
2. Call duthost.stop_service("swss") directly from duthost, instead of passing each asics inside the test_po_cleanup. to avoid execution sequence of test_po_cleanup[asic0], test_po_cleanup_after_reload[duthost], test_po_cleanup[asic1].

[judyjoseph]

@wenyiz2021 Can you port this PR to master branch also ?