Skip platform testcases if transceiver is DAC#5010
Merged
prgeor merged 4 commits intosonic-net:masterfrom Mar 14, 2022
Merged
Conversation
sujinmkang
previously approved these changes
Jan 27, 2022
prgeor
requested changes
Jan 27, 2022
Contributor
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
please reuse or fix is_xcvr_optical()
Contributor
|
i think this is already addressed by PR #4749 |
prgeor
requested changes
Feb 23, 2022
mannytaheri
requested review from
a team,
lolyu,
neethajohn,
wangxin and
yxieca
as code owners
prgeor
reviewed
Mar 3, 2022
Contributor
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
changes look good, except for the log message which is incorrect.
prgeor
reviewed
Mar 3, 2022
Contributor
Author
|
Addressed all the comments |
Contributor
|
@yxieca @lizhuhuams please cherry-pick this fix to 202012 |
yejianquan
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Added code to skip some testcases if transceiver is a DAC * modified test_sfp.py to use is_xcvr_optical instead of is_xcvr_dac * Addressed all the comments * Addressed more comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Added code snippet to skip certain platform_tests if the transceiver is a DAC
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Make the platform test cases more robust
How did you do it?
How did you verify/test it?
Ran the regression tests
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation