[sfp-refactor] Fix is_xcvr_optical for QSFP28/CMIS#4749
Merged
prgeor merged 2 commits intosonic-net:masterfrom Feb 2, 2022
Merged
[sfp-refactor] Fix is_xcvr_optical for QSFP28/CMIS#4749prgeor merged 2 commits intosonic-net:masterfrom
prgeor merged 2 commits intosonic-net:masterfrom
Conversation
prgeor
previously approved these changes
Nov 25, 2021
andywongarista
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@andywongarista is this PR still required? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Jan 31, 2022
Contributor
Author
Yes. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add additional check in is_xcvr_optical for passive QSFP28 cables. Also fix check for CMIS cables.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Passive QSFP28 cables may use an extended specification compliance code but this is not currently checked for in is_xcvr_optical, which results in some test cases inadvertently running and failing instead of being skipped.
Update check for CMIS cables to enable support for CMIS QSFP cables and address change in specification_compliance value introduced in sonic-net/sonic-platform-common#228
How did you do it?
Updated is_xcvr_optical to check for the extended specification compliance code. Based on SFF-8024 Table 4-4, this change assumes that passive cables have "CR" in the code description.
How did you verify/test it?
Ran sonic-mgmt test suite on Arista platfrom with QSFP28 passive cables/CMIS QSFP cables to verify.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation