Closed
Conversation
Contributor
|
can you resolve conflict? |
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Aug 2, 2025
…ompatibility. (sonic-net#493) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> In an Ansible playbook, the `vars` field must be defined as a dictionary (i.e., a set of key-value pairs), not as a list prefixed with -. When upgrading to a newer version of Ansible, the parser may enforce stricter validation on playbook syntax, which can result in errors like the following: ``` TASK [vm_set : Kickstart VMs] ************************************************** ERROR! Vars in a Task must be specified as a dictionary. The error appears to be in '/var/src/sonic-mgmt/ansible/roles/vm_set/tasks/kickstart_vm.yml': line 154, column 7, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: vars: - ansible_connection: 'network_cli' ^ here ``` This PR fixes the issue by correcting the structure of the vars section in the playbook to use the proper dictionary format, ensuring compatibility with newer Ansible versions and preventing similar errors in the future. Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? In an Ansible playbook, the `vars` field must be defined as a dictionary (i.e., a set of key-value pairs), not as a list prefixed with -. When upgrading to a newer version of Ansible, the parser may enforce stricter validation on playbook syntax, which can result in errors like the following: ``` TASK [vm_set : Kickstart VMs] ************************************************** ERROR! Vars in a Task must be specified as a dictionary. The error appears to be in '/var/src/sonic-mgmt/ansible/roles/vm_set/tasks/kickstart_vm.yml': line 154, column 7, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: vars: - ansible_connection: 'network_cli' ^ here ``` This PR fixes the issue by correcting the structure of the vars section in the playbook to use the proper dictionary format, ensuring compatibility with newer Ansible versions and preventing similar errors in the future. #### How did you do it? This PR fixes the issue by correcting the structure of the vars section in the playbook to use the proper dictionary format, ensuring compatibility with newer Ansible versions and preventing similar errors in the future. #### How did you verify/test it? We need to make sure that this change won't affect current test firstly -- test by pipeline itself. And then, we need to make sure that this change works in the new version -- test locally. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities 4488525..6b4d1a0: > [show vlan brief] Support 'alias' interface naming mode (sonic-net#497) > [show interface neighbor expected] Support 'alias' interface naming mode (sonic-net#495) > updated show ipv6 interface for alias mode (sonic-net#493) > [show] Add serial numbers/uptime/hwinfo to 'show version' output (sonic-net#488) > [show] show interface status added vlan and portchannels to command (sonic-net#483) Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-sairedis 4c75b7f..54c8e78: > [saisdkdump]: Fix dump generation crash (sonic-net#493) > Fix bug: Restore sai log levels from LOGLEVEL_DB after saiDiscover (sonic-net#491) Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tomatically (sonic-net#23283) #### Why I did it src/sonic-linux-kernel ``` * d10d26c - (HEAD -> 202405, origin/202405) [build] Use package.trafficmanager instead of sonicstorage.blob (sonic-net#493) (26 minutes ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update Sensor data for Dell S6100 platform
Fixes # (issue)
Type of change
Approach
Update the sensor data for S6100
Verified on Dell S6100 platform
Documentation