[pdu support] unify the PDU support naming convention#2960
[pdu support] unify the PDU support naming convention#2960yxieca merged 1 commit intosonic-net:masterfrom
Conversation
|
This pull request introduces 3 alerts and fixes 2 when merging 63d3eafb7ac72bb1cdecf726584a0617a2ba5bbc into 22402ac - view on LGTM.com new alerts:
fixed alerts:
|
|
@yxieca: I assume some of my review comments were hidden to you, because not all were addressed in your latest commit. |
you are right. I missed one push after running test for all_outlets changes. |
It looks like there are still unaddressed comments. Are they hidden/compressed for you? |
This comment has been minimized.
This comment has been minimized.
|
This pull request fixes 2 alerts when merging efbff69c93756863fd8d1d3253e31e566dd746d7 into ea6535e - view on LGTM.com fixed alerts:
|
The device external to the DUT that supply power to PSU (on DUT) is PDU. The unit send out power is outlet. This change unifies this concept in class names, function names and variables. No functional change is supposed to happen with this change. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
Addressed the merge conflict |
|
This pull request fixes 2 alerts when merging 7edbb94 into 451d052 - view on LGTM.com fixed alerts:
|
2 participants
Description of PR
Unify the naming convention of PDU and PSU
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
PDU/PSU was fix used in current code. The device external to the DUT that supply power to PSU (on DUT) is PDU. The unit send out power is outlet.
How did you do it?
This change unifies this concept in class names, function names and variables.
No functional change is supposed to happen with this change.
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?
Run following test and passed:
platform_tests/test_reboot.py::test_power_off_reboot
platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus
snmp/test_snmp_phy_entity.py::test_turn_off_pdu_and_check_psu_info
And validated devutils continue working.