Acl udp test#466
Closed
simone-dell wants to merge 7 commits intosonic-net:masterfrom
simone-dell:ACL-UDP-test
Closed
Acl udp test#466simone-dell wants to merge 7 commits intosonic-net:masterfrom simone-dell:ACL-UDP-test
simone-dell wants to merge 7 commits intosonic-net:masterfrom
simone-dell:ACL-UDP-test
Conversation
Added ICMP test - create ptf icmp packet and make sure it is rejected based on drop icmp rule
Contributor
Author
|
Add logs to verify the test |
Contributor
Author
matthew-soulsby
pushed a commit
to matthew-soulsby/sonic-mgmt
that referenced
this pull request
Jul 1, 2025
…c-net#466) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR is to cherry-pick sonic-net#19238 to 202503 branch. This PR is to enhance VM template to support route reflector. In DT2 topologies, the BGP sessions between FT2 and LT2 are IBGP. Hence, the routes learnt from exabgp, which is also IBGP session, are not advertised to DUT. To workaround this, this PR set VM as route reflector if the VM type is `lowerspine` or `fabricspine`. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? This PR is to support route reflector in VM template. #### How did you do it? Check VM type and enable route reflector if VM type is `lowerspine` or `fabricspine`. #### How did you verify/test it? The change is verified on a physical testbed. #### Any platform specific information? No. #### Supported testbed topology if it's a new test case? Not a new test. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it? Added a rule in the json file that calls for dropping of udp packets
How did you verify/test it? In my local. Both using ansible and running python script in PTF container. Create a rule that denies udp packets. Create a simple udp packet and verify it is not received on any ports.
Any platform specific information? No
Supported testbed topology if it's a new test case? t1, t1-lag, t1-64-lag
Documentation