Set VM as reflector for LT2/FT2#19238
Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom Jun 29, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
approved these changes
Jun 28, 2025
11 tasks
Collaborator
Author
|
PR to 202503 Azure/sonic-mgmt.msft#466 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
* Set VM as reflector for LT2/FT2
Collaborator
|
Cherry-pick PR to 202505: #19250 |
11 tasks
bingwang-ms
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jun 30, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR is to cherry-pick sonic-net/sonic-mgmt#19238 to 202503 branch. This PR is to enhance VM template to support route reflector. In DT2 topologies, the BGP sessions between FT2 and LT2 are IBGP. Hence, the routes learnt from exabgp, which is also IBGP session, are not advertised to DUT. To workaround this, this PR set VM as route reflector if the VM type is `lowerspine` or `fabricspine`. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? This PR is to support route reflector in VM template. #### How did you do it? Check VM type and enable route reflector if VM type is `lowerspine` or `fabricspine`. #### How did you verify/test it? The change is verified on a physical testbed. #### Any platform specific information? No. #### Supported testbed topology if it's a new test case? Not a new test. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
matthew-soulsby
pushed a commit
to matthew-soulsby/sonic-mgmt
that referenced
this pull request
Jul 1, 2025
* Set VM as reflector for LT2/FT2
mssonicbld
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Set VM as reflector for LT2/FT2
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
* Set VM as reflector for LT2/FT2
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
* Set VM as reflector for LT2/FT2
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
* Set VM as reflector for LT2/FT2
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
* Set VM as reflector for LT2/FT2 Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
* Set VM as reflector for LT2/FT2 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
* Set VM as reflector for LT2/FT2 Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
* Set VM as reflector for LT2/FT2 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
* Set VM as reflector for LT2/FT2
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
* Set VM as reflector for LT2/FT2 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
* Set VM as reflector for LT2/FT2 Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to enhance VM template to support route reflector.
In DT2 topologies, the BGP sessions between FT2 and LT2 are IBGP. Hence, the routes learnt from exabgp, which is also IBGP session, are not advertised to DUT.
To workaround this, this PR set VM as route reflector if the VM type is
lowerspineorfabricspine.Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to support route reflector in VM template.
How did you do it?
Check VM type and enable route reflector if VM type is
lowerspineorfabricspine.How did you verify/test it?
The change is verified on a physical testbed.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test.
Documentation