Prevent Portchannel Overlap for Internal and External Portchannel#4576
Merged
abdosi merged 16 commits intosonic-net:masterfrom Oct 28, 2021
Merged
Prevent Portchannel Overlap for Internal and External Portchannel#4576abdosi merged 16 commits intosonic-net:masterfrom
abdosi merged 16 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
SuvarnaMeenakshi
requested changes
Oct 28, 2021
Contributor
SuvarnaMeenakshi
left a comment
SuvarnaMeenakshi
left a comment
There was a problem hiding this comment.
PortChannel interface name in the below section also needs to be updated.
{%- set acl_intfs = [] -%}
{% if card_type is not defined or card_type != 'supervisor' %}
{%- for index in range(vms_number) %}
{% if vms[index] in vm_asic_ifnames and vm_asic_ifnames[vms[index]][0].split('-')[1] == asic_name %}
{% if 'port-channel' in vm_topo_config['vm'][vms[index]]['ip_intf'][0]|lower %}
{% set a_intf = 'PortChannel' + ((index+1) |string).zfill(2) %}
{{- acl_intfs.append(a_intf) -}}
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Contributor
Author
|
@SuvarnaMeenakshi Thanks for catching that. Updated. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:-
Avoid Overlap of External and Internal PortChannel. This can happen when we have many port-channel interfaces in case of t2 topo.
How I did:-
External Port Channel will be 4 digit and Internal Port-Channel will be 2 digit.