[advance-reboot] Separate server IP range for control and data plane traffic#4525
Merged
vaibhavhd merged 1 commit intosonic-net:masterfrom Oct 22, 2021
Merged
Conversation
prsunny
approved these changes
Oct 21, 2021
shi-su
approved these changes
Oct 21, 2021
yxieca
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: To fix the small number of packet drops (during warmreboot), separate the IP network to check control plane and data planes.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix the issue of small number of packet drops seen during warm recovery path in devices with too many vlan ports.
In the device with too many vlan ports, after PR #4152, all the neighbors are exercised (instead on just 1 before).
PTF can drop one of the MANY packets, and DUT may think that neighbor is unreachable.
The packet drop happens when neighbor entry is removed by kernel as the neighbor state becomes UNREACHABLE/DELETE.
How did you do it?
Separate the IP network to check control plane and data planes.
This is done so to prevent few packet drops after warmboot in case of device with too many vlan ports.
How did you verify/test it?
Tested on 7260 testbed (more than 100 vlan ports).
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation