[Advanced-reboot] Assign MAC addresses to ping packets by shi-su · Pull Request #4152 · sonic-net/sonic-mgmt

shi-su · 2021-08-31T22:25:24Z

Description of PR

Summary: Assign MAC addresses to ping packets
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911

Approach

What is the motivation for this PR?

A part of the ping packets for advanced reboot is not provided with a source mac address. It follows that the default mac address (00:06:07:08:09:0A) is used for packets from different ports. The DUT may generate a large number of unexpected fdb notifications.

An example recording of the issue before fix

2021-04-19.17:42:35.331743|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015d2"}]}]|
2021-04-19.17:42:35.332599|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a000000001947"}]}]|
2021-04-19.17:42:35.333195|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a000000001947"}]}]|
2021-04-19.17:42:35.333689|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015fa"}]}]|
2021-04-19.17:42:35.334151|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015fa"}]}]|
2021-04-19.17:42:35.334624|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015f0"}]}]|
2021-04-19.17:42:35.335514|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015f0"}]}]|
2021-04-19.17:42:35.335983|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a00000000156a"}]}]|
2021-04-19.17:42:35.336356|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a00000000156a"}]}]|
2021-04-19.17:42:35.336742|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a000000001598"}]}]|
2021-04-19.17:42:35.337127|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a000000001598"}]}]|
2021-04-19.17:42:35.337540|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a00000000192b"}]}]|
2021-04-19.17:42:35.337926|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a00000000192b"}]}]|
2021-04-19.17:42:35.338335|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015f4"}]}]|
2021-04-19.17:42:35.338684|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015f4"}]}]|
2021-04-19.17:42:35.339066|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a00000000158e"}]}]|
2021-04-19.17:42:35.339428|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a00000000158e"}]}]|
2021-04-19.17:42:35.339822|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015a6"}]}]|
2021-04-19.17:42:35.340182|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015a6"}]}]|
2021-04-19.17:42:35.340564|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015b2"}]}]|
2021-04-19.17:42:37.364438|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015b2"}]}]|
2021-04-19.17:42:37.364856|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015d2"}]}]|
2021-04-19.17:42:40.349180|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015d2"}]}]|
2021-04-19.17:42:40.350129|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015f8"}]}]|
2021-04-19.17:42:40.351145|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015f8"}]}]|
2021-04-19.17:42:40.351767|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015ec"}]}]|
2021-04-19.17:42:40.351987|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015ec"}]}]|
2021-04-19.17:42:40.352727|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015bc"}]}]|
2021-04-19.17:42:40.353389|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015bc"}]}]|
2021-04-19.17:42:40.354104|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_LEARNED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015ee"}]}]|
2021-04-19.17:42:40.354876|n|fdb_event|[{"fdb_entry":"{\"bvid\":\"oid:0x26000000001563\",\"mac\":\"00:06:07:08:09:0A\",\"switch_id\":\"oid:0x21000000000000\"}","fdb_event":"SAI_FDB_EVENT_AGED","list":[{"id":"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID","value":"oid:0x3a0000000015ee"}]}]|

How did you do it?

Assign mac address to ping packets.

How did you verify/test it?

Run the test and verify the unexpected notifications does not show up.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

A part of the ping packets for advanced reboot is not provided with a source mac address. It follows that the default mac address (00:06:07:08:09:0A) is used for packets from different ports. The DUT may generate a large number of unexpected fdb notifications. Assign mac address to ping packets to avoid the behavior.

… traffic (#4525) To fix the issue of small number of packet drops seen during warm recovery path in devices with too many vlan ports. In the device with too many vlan ports, after PR #4152, all the neighbors are exercised (instead on just 1 before). PTF can drop one of the MANY packets, and DUT may think that neighbor is unreachable. The packet drop happens when neighbor entry is removed by kernel as the neighbor state becomes UNREACHABLE/DELETE. Changes in this PR: Separate the IP network to check control plane and data planes. This is done so to prevent few packet drops after warmboot in case of device with too many vlan ports.

…lly (#25637) #### Why I did it src/sonic-swss ``` * dbe0768e - (HEAD -> master, origin/master, origin/HEAD) Fix the "Invalid BUFFER QUEUE" error (sonic-net#4224) (6 hours ago) [saksarav-nokia] * d29d7ea1 - This patch is to fix a major bug in the for loop of the function AclRange::remove. (sonic-net#4256) (9 hours ago) [ashishalok-arista] * 35288a65 - Fix performance issue in fpmsyncd for non-ZMQ configuration (sonic-net#4219) (9 hours ago) [venkit-nexthop] * 1c384fb6 - Merge pull request sonic-net#4022 from ksravani-hcl/swss_1 (12 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 36d98d61 - Enable response pipeline for P4Orch. (22 hours ago) [mint570] |/ * 63860664 - [build] Add docker-based build environment (sonic-net#3715) (22 hours ago) [Lawrence Lee] * 26ec7561 - [buffermgrd] Wait for lossless buffer profile to be applied to SAI (sonic-net#4154) (23 hours ago) [ganglv] * 599eae77 - [tunnel] use warning message when setting a create-only attribute (sonic-net#4212) (27 hours ago) [Yakiv Huryk] * ebf8c73f - [orchagent] Fix getopt string for -R option (ring_thread_enabled regression) (sonic-net#4207) (27 hours ago) [Chiranjeevi U - MapleLabs] * aa081017 - Avoid using an uninitialized source MAC address (sonic-net#4201) (28 hours ago) [Andriy Yurkiv] * 2a258c2 - Added mux neighbor_mode support with prefix-route (sonic-net#4152) (31 hours ago) [manamand2020] * 9616cd52 - [ci] Install redis from Debian (sonic-net#4241) (34 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog

add mac for ping dut and ping from servers

18a935d

shi-su marked this pull request as ready for review August 31, 2021 23:47

shi-su requested a review from a team as a code owner August 31, 2021 23:47

shi-su requested review from stepanblyschak and vaibhavhd August 31, 2021 23:47

vaibhavhd approved these changes Sep 9, 2021

View reviewed changes

shi-su merged commit c039cd3 into sonic-net:master Sep 10, 2021

vaibhavhd mentioned this pull request Oct 21, 2021

[advance-reboot] Separate server IP range for control and data plane traffic #4525

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Advanced-reboot] Assign MAC addresses to ping packets#4152

[Advanced-reboot] Assign MAC addresses to ping packets#4152
shi-su merged 1 commit intosonic-net:masterfrom
shi-su:fast_reboot_mac

shi-su commented Aug 31, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shi-su commented Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shi-su commented Aug 31, 2021 •

edited

Loading