Merged
Conversation
wangxin
reviewed
Sep 16, 2021
tests/arp/test_neighbor_mac_noptf.py
Outdated
| for intf, status in intfStatus.items(): | ||
| if "routed" in status["vlan"] and "up" in status["oper_state"]: | ||
| testRoutedInterface[asichost.asic_index] = intf | ||
| return testRoutedInterface |
Collaborator
There was a problem hiding this comment.
Only routed interfaces of the first ASIC would be returned. Is this expected? Need to reduce indention of return testRoutedInterface?
Contributor
Author
|
Done |
wangxin
approved these changes
Sep 18, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
… improve stability (sonic-net#4291) In setupDutConfig of this test, it will do config reload, and the wait time is 120s. Sometimes for some platforms such as sn3800, 120s is not enough for interface to be up. So use wait_until to check the interface is up or not, it will make the test more stable. What is the motivation for this PR? Use wait_until to check the interface is up or not, and make the test more stability. How did you do it? Use wait_until to check the interface is up or not. How did you verify/test it? run the test : test_neighbor_mac_noptf.py
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (#25595) #### Why I did it src/sonic-utilities ``` * ddc241ec - (HEAD -> 202511, origin/202511) [storm-control] Fixed show storm-control interface command display (sonic-net#4302) (32 hours ago) [mssonicbld] * fbd3f90b - [fast-reboot][cosmetic] Fixed debug/error prints with the correct reboot type (sonic-net#4286) (5 days ago) [Yair Raviv] * efdffa2a - Added counterpoll CLI support (sonic-net#4291) (6 days ago) [mssonicbld] * 567ad5b3 - [Smartswitch] Prevent early exit of reboot status (sonic-net#4287) (6 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
In setupDutConfig of this test, it will do config reload, and the wait time is 120s. Sometimes for some platforms such as sn3800, 120s is not enough for interface to be up. So use wait_until to check the interface is up or not, it will make the test more stable.
Type of change
Back port request
Approach
What is the motivation for this PR?
Use wait_until to check the interface is up or not, and make the test more stability.
How did you do it?
Use wait_until to check the interface is up or not.
How did you verify/test it?
run the test : test_neighbor_mac_noptf.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation