[dual-tor] Add retry to get the port mac from ptf#4287
Merged
kevinskwang merged 1 commit intosonic-net:masterfrom Sep 17, 2021
Merged
[dual-tor] Add retry to get the port mac from ptf#4287kevinskwang merged 1 commit intosonic-net:masterfrom
kevinskwang merged 1 commit intosonic-net:masterfrom
Conversation
What is the motivation for this PR? It may fail to get the MAC address from ptf, but in current test case, it just steps forward even the return value is None. How did you do it? Add retry 10 times to get the port MAC address from PTF. How did you verify/test it? Run dualtor/test_orchagent_active_tor_downstream.py test case. Signed-off-by: Kevin(Shengkai) Wang <[email protected]>
wangxin
approved these changes
Sep 16, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
What is the motivation for this PR? It may fail to get the MAC address from ptf, but in current test case, it just steps forward even the return value is None. How did you do it? Add retry 10 times to get the port MAC address from PTF. How did you verify/test it? Run dualtor/test_orchagent_active_tor_downstream.py test case. Signed-off-by: Kevin(Shengkai) Wang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (#25595) #### Why I did it src/sonic-utilities ``` * ddc241ec - (HEAD -> 202511, origin/202511) [storm-control] Fixed show storm-control interface command display (sonic-net#4302) (32 hours ago) [mssonicbld] * fbd3f90b - [fast-reboot][cosmetic] Fixed debug/error prints with the correct reboot type (sonic-net#4286) (5 days ago) [Yair Raviv] * efdffa2a - Added counterpoll CLI support (sonic-net#4291) (6 days ago) [mssonicbld] * 567ad5b3 - [Smartswitch] Prevent early exit of reboot status (sonic-net#4287) (6 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
It may fail to get the MAC address from ptf, but in current test case, it just steps forward even the return value is None.
How did you do it?
Add retry 10 times to get the port MAC address from PTF.
How did you verify/test it?
Run dualtor/test_orchagent_active_tor_downstream.py test case.
Signed-off-by: Kevin(Shengkai) Wang [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation