upgrade ceos to version 4.25.5.1M, fix the issue of arista endless loop#4252

Closed

yejianquan wants to merge 9 commits intosonic-net:masterfrom

yejianquan:jianquanye/for_merge

Collaborator

yejianquan commented Sep 14, 2021

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911

Approach

What is the motivation for this PR?

cEOS containers' mgmt-ip occasionally unavaillable, upgrade cEOS image version will fix that
cEOS terminal behavior slightly different from vEOS, enhance arista.py to avoid endless loop

How did you do it?

upgrade cEOS image version
break loop if ssh connect returns merely an 'exit', as for other commands who relies on the return e.g. 'show interfaces po1 | json', 'exit' won't appear in input_buffer, so the change won't influence it.

How did you verify/test it?

Run platform_tests/test_advanced_reboot.py test on physical testbed and it didn't stuck again.
Tried run command 'show interfaces po1 | json', it's not influenced.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

yejianquan requested a review from a team as a code owner

September 14, 2021 03:00

diaryevil approved these changes

View reviewed changes

Contributor

lguohan commented Sep 14, 2021

please investigate the test error


          upgrade ceos to version 4.25.5.1M, fix the issue of arista endless lo…

578af0d

…pp (sonic-net#4228)

Description of PR
Summary:
Fixes # (issue)

Type of change
 Bug fix
 Testbed and Framework(new/improvement)

Approach
What is the motivation for this PR?
cEOS containers' mgmt-ip occasionally unavaillable, upgrade cEOS image version will fix that
cEOS terminal behavior slightly different from vEOS, enhance arista.py to avoid endless loop

How did you do it?
upgrade cEOS image version
break loop if ssh connect returns merely an 'exit', as for other commands who relies on the return e.g. 'show interfaces po1 | json', 'exit' won't appear in input_buffer, so the change won't influence it.

How did you verify/test it?
Run platform_tests/test_advanced_reboot.py test on physical testbed and it didn't stuck again.
Tried run command 'show interfaces po1 | json', it's not influenced.

Co-authored-by: Jianquan Ye <[email protected]>

yejianquan force-pushed the jianquanye/for_merge branch from 63a2e3c to 578af0d Compare

September 14, 2021 06:35

yejianquan changed the title ~~upgrade ceos to version 4.25.5.1M, fix the issue of arista endless lopp~~ upgrade ceos to version 4.25.5.1M, fix the issue of arista endless loop

yejianquan added 2 commits

September 14, 2021 19:56


          Update lacp show command to compatible with cEOS version

630fd99


          prolong ceos mgmt-ip timeout threshold

def91da

yejianquan force-pushed the jianquanye/for_merge branch from 1c8c09d to 255cd02 Compare

September 15, 2021 06:28

Collaborator Author

yejianquan commented Sep 15, 2021

please investigate the test error

'show lacp neighbor' command is deprecated by 'show lacp peer', fixed

yejianquan requested review from lguohan and wangxin

September 15, 2021 06:45

Collaborator Author

yejianquan commented Sep 15, 2021 •

edited

Loading

Compatible with older EOS version by execute both 'show lacp neighbor' and 'show lacp peer', and select success returned one as result.
Didn't choose to maintain a EOS version-> command mapping, because it's hard to enum all the EOS versions we're using, and will be difficulty to maintian if we will have more EOS versions in the future, the people who upgrade EOS version may not be awared of there's a map to be update.
If we set 'show lacp peer' as default to avoid the issue, it will hurt backward compatibility.

So choose to execute all equivalent commands to have the most robust.


          compatible with different EOS versions

ddb1b3a

yejianquan force-pushed the jianquanye/for_merge branch from 255cd02 to ddb1b3a Compare

September 15, 2021 07:01

lguohan reviewed

View reviewed changes

ansible/group_vars/all/ceos.yml Show resolved Hide resolved


          comment rather than delete

665c471

Collaborator Author

yejianquan commented Sep 15, 2021 •

edited

Loading

Something stuck platform_tests/test_advanced_reboot.py::test_warm_reboot,
the phenomenon is: platform_tests/test_advanced_reboot.py::test_warm_reboot can pass in single run, but stuck if run whole platform_tests/test_advanced_reboot.py, guess VMs' status is changed in previous step,

I'm investigating it.

Collaborator Author

yejianquan commented Sep 16, 2021

/azp run

azure-pipelines bot commented Sep 16, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 16, 2021

/azp run

azure-pipelines bot commented Sep 16, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 16, 2021

/azp run

azure-pipelines bot commented Sep 16, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 16, 2021

/azp run

azure-pipelines bot commented Sep 16, 2021

Azure Pipelines successfully started running 1 pipeline(s).


          add logs

9625c58

Collaborator Author

yejianquan commented Sep 17, 2021

/azp run

azure-pipelines bot commented Sep 17, 2021

Azure Pipelines successfully started running 1 pipeline(s).


          add log

bd42446

fix

5074f09

Collaborator Author

yejianquan commented Sep 17, 2021

/azp run

azure-pipelines bot commented Sep 17, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 18, 2021

/azp run

azure-pipelines bot commented Sep 18, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 18, 2021

/azp run

azure-pipelines bot commented Sep 18, 2021

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan force-pushed the jianquanye/for_merge branch 3 times, most recently from 85797eb to 671348e Compare

September 20, 2021 13:02


          add paramiko ssh command timeout control

6ff65a9

yejianquan force-pushed the jianquanye/for_merge branch from 671348e to 6ff65a9 Compare

September 20, 2021 13:04

Collaborator Author

yejianquan commented Sep 21, 2021

/azp run

azure-pipelines bot commented Sep 21, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 21, 2021

/azp run

azure-pipelines bot commented Sep 21, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 21, 2021

/azp run

azure-pipelines bot commented Sep 21, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator Author

yejianquan commented Sep 24, 2021

split into three prs to reduce the possible affection, close this one

yejianquan closed this

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request


          [submodule] Update submodule sonic-utilities to the latest HEAD autom…

a732689

…atically (#25250)

#### Why I did it
src/sonic-utilities
```
* 0315da21 - (HEAD -> 202511, origin/202511) [LACP retry-count] Syntax Fix for Trixie (sonic-net#4280) (6 hours ago) [Yair Raviv]
* 4420954e - Fix dump port state CLI command crash on multi-asic platforms (#4276) (5 days ago) [mssonicbld]
* a3ad30be - [Mellanox] Add restricted sysfs list for fw control modules (sonic-net#4202) (13 days ago) [mssonicbld]
* 16390921 - Fix j2 files not getting packaged (sonic-net#4252) (13 days ago) [mssonicbld]
* 6b9b0dce - [hft]: HFT config/show cli (sonic-net#4243) (2 weeks ago) [mssonicbld]
* 529b6479 - [sfputil] Fix issue: should not do low power mode or reset for non-present ports (sonic-net#4241) (2 weeks ago) [mssonicbld]
* ad70c8f2 - Update bash completions for sonic-utilities commands (sonic-net#4234) (3 weeks ago) [mssonicbld]
* 667f4b32 - [202511][GCU] Update WRED_PROFILE and BUFFER_POOL validators for GCU (sonic-net#4226) (3 weeks ago) [Dev Ojha]
* 88b3899d - Fix sonic-kdump-config for running commands with pipe (sonic-net#4220) (3 weeks ago) [mssonicbld]
* e4881b02 - Skip IP range duplicate check in validate_bgp_peer_group for different vnets (sonic-net#4215) (4 weeks ago) [mssonicbld]
* 9c24925a - Fix syntax and semantic errors in kdump remote feature (sonic-net#4212) (4 weeks ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet