Skip to content

[Mellanox] Modify AbnormalFanMocker check_result return value #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangxin merged 1 commit into from
Sep 11, 2021
Merged

[Mellanox] Modify AbnormalFanMocker check_result return value #4192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/platform_tests/mellanox/mellanox_thermal_control_test_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,14 +1003,16 @@ def check_result(self, actual_data):
if fan['fan'] == self.fan_data.name:
try:
actual_color = self.fan_drawer_data.get_status_led()
assert actual_color == self.expect_led_color, 'FAN {} color is {}, expect: {}'.format(fan['fan'],
actual_color,
self.expect_led_color)
if actual_color != self.expect_led_color:
logging.error('FAN {} color is {}, expect: {}'.format(fan['fan'], actual_color,
self.expect_led_color))
return False
except SysfsNotExistError as e:
logging.info('LED check only support on SPC2 and SPC3: {}'.format(e))
return
return True

assert 0, 'Expected data not found'
logging.error('Expected data not found')
return False

def is_fan_removable(self):
"""
Expand Down