[Mellanox] Modify AbnormalFanMocker check_result return value#4192
Merged
wangxin merged 1 commit intosonic-net:masterfrom Sep 11, 2021
Merged
Conversation
Return True if the actual fan data is same with the mock data, else return False.
keboliu
approved these changes
Sep 7, 2021
sujinmkang
approved these changes
Sep 10, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
What is the motivation for this PR? The test case "test_thermal_control_fan_status" will failed after the PR sonic-net#3684 is merged How did you do it? Change the return value of the check_result in AbnormalFanMocker, before the sonic-net#3684 is merged, it dose not care about the return value of the check_result in AbnormalFanMocker, after the PR is merged, it will check the return value of the check_result How did you verify/test it? Run test cases in test_platform_info.py and all the test cases pass
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (#25405) #### Why I did it src/sonic-swss ``` * 13227d02 - (HEAD -> 202511, origin/202511) [countersyncd]: Add communication statistics recording and utilities (sonic-net#4222) (2 days ago) [mssonicbld] * 3c4d3b2b - [countersyncd]: Add retry between client and otel collector (sonic-net#4220) (3 days ago) [mssonicbld] * 77acf5a0 - [countersyncd] fix otel actor log level (sonic-net#4221) (3 days ago) [mssonicbld] * 03ec77c7 - [countersyncd]: Add benchmark suite for countersyncd and optimize otel actor (sonic-net#4216) (5 days ago) [mssonicbld] * 08050f2e - [hft]: Fix TAM type capability enable list (sonic-net#4215) (6 days ago) [mssonicbld] * d0793b45 - [Fixbug]: Fix delete default HFT configuration issue (sonic-net#4138) (7 days ago) [mssonicbld] * 246d9575 - [hft]: Enable output queue for HFT (sonic-net#4187) (7 days ago) [mssonicbld] * ae6a9887 - [countersyncd]: Fix netlink fd leakage and deadlock issue (sonic-net#4191) (7 days ago) [mssonicbld] * c468e1fc - [countersyncd]: Fix compiling warning of otel (sonic-net#4192) (7 days ago) [mssonicbld] * d675062c - Enabling the FEC histogram for gbsyncd counters (sonic-net#4195) (9 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return True if the actual fan data is same with the mock data, else return False.
Description of PR
Summary: Modify AbnormalFanMocker check_result return value
Fixes # (issue) Modify AbnormalFanMocker check_result return value to make test case "test_thermal_control_fan_status" pass
Type of change
Back port request
Approach
What is the motivation for this PR?
The test case "test_thermal_control_fan_status" will failed after the PR #3684 is merged
How did you do it?
Change the return value of the check_result in AbnormalFanMocker, before the #3684 is merged, it dose not care about the return value of the check_result in AbnormalFanMocker, after the PR is merged, it will check the return value of the check_result
How did you verify/test it?
Run test cases in test_platform_info.py and all the test cases pass
Any platform specific information?
No, it happens on any kind of platform