Merged
Conversation
lguohan
approved these changes
Jan 6, 2018
lguohan
reviewed
Jan 6, 2018
| mtu: | ||
| filename: mtu.yml | ||
| topologies: [t1, t1-lag] | ||
| execvars: |
lguohan
approved these changes
Jan 8, 2018
praveen-li
pushed a commit
to praveen-li/sonic-mgmt
that referenced
this pull request
Jun 20, 2019
* msft_github/master: [PFCWD]: Add Add support for t0 toplogy and arista fanout testbed (sonic-net#424) add orchagent process check before each test and sanity after each test (sonic-net#431) Move mem_check.sh into helpers/ directory to conform with location of other helper scripts (sonic-net#435) fix tests for t0-116 topology (sonic-net#430) Updated labinfo file with Arista fanout sku (sonic-net#429) add missing snmp testcases to top level snmp.yml; fixed wrong test file for neighbour test; change arp test comment more readable (sonic-net#428) Fix sku-sensors-data for 7060 (sonic-net#427) Fix port alias mapping for Arista-7050QX-32S (sonic-net#426) [Lag 2] Allow lacp timing tests to retry limited times until succeeded (sonic-net#403) [hwsku]: Add Accton-AS7716-32X (sonic-net#405) add generate minigrah using testbed_name option (sonic-net#425) Update README.testbed.md Create README.testbed.Example.md Update README.testbed.Config.md add missing test case name (sonic-net#417) fix typo when assign dscp_mode for decap test (sonic-net#418) [repeat harness] rework repeat harness and introduce test case continuous reboot (sonic-net#416) allow upgrade sonic via onie or sonic-to-sonic upgrade method (sonic-net#413) [topology]: Fix t1-64-lag topology device link base indices (sonic-net#414) Run sudo command with log_analyzer (sonic-net#415) [sonic tests] use host time instead of ansible time (sonic-net#410) [upgrade_sonic]: Fix the hostname in the wait_for condition (sonic-net#411) [Test cases] clean up some test cases changes and enabling more tests (sonic-net#409) add restart_swss (sonic-net#412) [sonic test] introduce a repeat harness (sonic-net#402) Update README.test.md [bgp_speaker]: always clean up test environment after it finishes (sonic-net#406) [vlan]: add vlan test to test by testname (sonic-net#408) [bug]: convert the interface from unicode to string (sonic-net#407) [VLAN test] Add VLAN test (sonic-net#375) [vm]: change the default Front plane port to 4 instead of 8 (sonic-net#404) Update README.testbed.Setup.md [acl]: Adopt tests with acl-loader to t0 and t1-lag topo. (sonic-net#370) add connect_topo command for testbed-cli.sh (sonic-net#398) [FIB, BGP speaker] fix t0-116 topology source port list (sonic-net#396) [bgp_speaker]: Specify VLAN IP route in case LPM to other nexthop (sonic-net#394) [sensor]: Change sensor labels for Arista 7050 and 7260 (sonic-net#395) Delete Arista DPMs sensors data (sonic-net#393) [bug]: change maximum packet to 9114 to send in the mtu test (sonic-net#391)
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Jun 27, 2025
…sonic-net#18790) (sonic-net#417) Cherry-pick sonic-net#18790 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR add option to use batch_mode support for bind_fp_ports. Which improves the speed by 50% tested on 128 VM neighbor. Fixes # (issue) 32654908 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? When doing ovs flow creation, we're launching subprocess and waiting for each subprocess result before continue with the next call. This process is very inefficient even with the aid of multi-threading support. #### How did you do it? This PR change the behavior of multi-threading in the following way: 1. Batching all the ovs flow creation commands that needed to execute into a single file 2. Launch 1 process to call `ovs-ofctl` on the file using add-flows, put the process into queue for wait later and free the thread so that the same thread can be use to launch a different batch 3. In the end, main thread will wait for all the batches launched from process finished This PR also provide an options to opt in this feature #### How did you verify/test it? Verified on physical testbed with 128 VMs. Time deduction for the same settings of 8 Threads is reduced from 1 hour 30 minutes to 45 minutes average. The following is a sample of the same settings, same number of threads, with batch_mode enabled on renumber topology and unbind topology. We can see the majority of benefit in Renumber topology by batch the bind_fp_ports. Before ``` Wednesday 04 June 2025 03:12:40 +0000 (0:00:00.055) 1:43:10.602 ******** =============================================================================== vm_set : Renumber topology lt2-o128 to VMs. base vm = VM73166 -------- 4998.28s vm_set : Unbind topology lt2-o128 to VMs. base vm = VM73166 ----------- 557.45s vm_set : Kill exabgp and ptf_nn_agent processes in PTF container ------ 206.43s vm_set : Setup vlan port for vlan tunnel ------------------------------- 92.35s vm_set : Verify that exabgp processes for IPv4 are started ------------- 45.90s vm_set : Verify that exabgp processes for IPv6 are started ------------- 45.79s vm_set : Configure exabgp processes for IPv4 on PTF -------------------- 27.62s vm_set : configure exabgp processes for IPv6 on PTF -------------------- 26.66s vm_set : Stop ptf container ptf_vms73-2 -------------------------------- 16.49s vm_set : Run the "apt-get update" as a separate and retryable step ----- 14.26s vm_set : Create ptf container ptf_vms73-2 ------------------------------ 14.25s vm_set : Try to login into docker registry ----------------------------- 12.00s vm_set : Remove ptf container ptf_vms73-2 ------------------------------ 11.54s vm_set : Set ipv6 route max size of ptf_vms73-2 ------------------------ 11.13s vm_set : Enable ipv6 for docker container ptf_vms73-2 ------------------ 11.03s vm_set : Install necessary packages ------------------------------------ 10.58s vm_set : Announce routes ------------------------------------------------ 9.99s vm_set : Install necessary packages ------------------------------------- 9.09s vm_set : Stop PTF portchannel ------------------------------------------- 4.60s vm_set : Change PTF interface MAC addresses ----------------------------- 4.35s ``` **After** ``` Wednesday 04 June 2025 07:30:07 +0000 (0:00:00.069) 0:52:51.148 ******** =============================================================================== vm_set : Renumber topology lt2-o128 to VMs. base vm = VM73166 -------- 1980.45s vm_set : Unbind topology lt2-o128 to VMs. base vm = VM73166 ----------- 552.96s vm_set : Kill exabgp and ptf_nn_agent processes in PTF container ------ 206.56s vm_set : Setup vlan port for vlan tunnel ------------------------------ 108.52s vm_set : Verify that exabgp processes for IPv4 are started ------------- 45.76s vm_set : Verify that exabgp processes for IPv6 are started ------------- 45.45s vm_set : Configure exabgp processes for IPv4 on PTF -------------------- 27.49s vm_set : configure exabgp processes for IPv6 on PTF -------------------- 25.96s vm_set : Stop ptf container ptf_vms73-2 -------------------------------- 16.17s vm_set : Create ptf container ptf_vms73-2 ------------------------------ 15.02s vm_set : Remove ptf container ptf_vms73-2 ------------------------------ 12.38s vm_set : Set ipv6 route max size of ptf_vms73-2 ------------------------ 11.56s vm_set : Try to login into docker registry ----------------------------- 11.13s vm_set : Install necessary packages ------------------------------------ 10.50s vm_set : Install necessary packages ------------------------------------- 8.84s vm_set : Announce routes ------------------------------------------------ 7.81s vm_set : Run the "apt-get update" as a separate and retryable step ------ 6.45s vm_set : Add exabgpv6 supervisor config and start related processes ----- 4.74s vm_set : Change PTF interface MAC addresses ----------------------------- 4.67s vm_set : Stop PTF portchannel ------------------------------------------- 4.51s ``` # Other topology The only affected functionality are `renumber topology` and `unbind topology` | topology | no batch | batch| |-----------|--------|---------| |t0|| | |t1-64-lag||| |dualtor-120||| #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…ules (sonic-net#2569) PR#2538 cannot merge due to master branch status. It has been tested against 201811 branch. Submodule src/sonic-sairedis 21f4a49..d57222a: > Add more specific logic for ingress ACL and buffer profile (sonic-net#421) > Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (sonic-net#418) > Add support for vlan tagged frames in virtual switch (sonic-net#417) Submodule src/sonic-swss 1590030..584490c: > Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (sonic-net#786) > [vstest]: Potential fix for timing issue in warm_reboot's routing UT (sonic-net#788) Submodule src/sonic-swss-common 594f4e8..286ef34: > Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (sonic-net#260) Submodule src/sonic-utilities c6666e2..b44b462: > Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABL… (sonic-net#458) > [aclshow] output only counters per table/rule (sonic-net#442) Signed-off-by: Ying Xie <[email protected]> [PR 2538] Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE Signed-off-by: Jipan Yang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (#24418) #### Why I did it src/sonic-gnmi ``` * d044158 - (HEAD -> 202411, origin/202411) Merge pull request sonic-net#417 from FengPan-Frank/temptest (sonic-net#535) (2 days ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it?
adding two additional test case names missed before
How did you verify/test it?
Run some local tests to make sure test run didn't break. Not verify the named test cases.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation