Skip to content

Enhancing test_cont_link_flap to work on a multi-asic box.#3992

Merged
yxieca merged 3 commits intosonic-net:masterfrom
rawal01:link_flap
Jan 14, 2022
Merged

Enhancing test_cont_link_flap to work on a multi-asic box.#3992
yxieca merged 3 commits intosonic-net:masterfrom
rawal01:link_flap

Conversation

@rawal01
Copy link
Contributor

@rawal01 rawal01 commented Aug 9, 2021

Description of PR

Summary:
Fixes # (issue)
test_cont_link flap fails for multi-asic box

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

The commands 'show processes cpu', 'show ip route summary' and 'show ipv6 route summary' return output for all the asics on a multi-asic card.

How did you do it?

We check each asic's 'Total' routes before and after the link flap.

  • instead of assigning stdout we are assigning stdout_lines from ourput which will be list of values per line for each asic.
  • At end of test we compare one to one for each value from list of routes

Similarly we check cpu util for each orchagent process running per asic.

  • instead of assigning stdout we are assigning stdout_lines from ourput which will be list of values per line for each asic.
  • At end of test we compare one to one for each value from list of orchagent processes running

How did you verify/test it?

Verified test on a single asic and multi-asic box.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@rawal01 rawal01 requested a review from sujinmkang as a code owner August 9, 2021 16:03
@sujinmkang sujinmkang requested a review from a team August 11, 2021 17:51
@sujinmkang sujinmkang requested a review from yxieca August 22, 2021 22:49
ysmanman
ysmanman previously approved these changes Sep 15, 2021
@arlakshm
Copy link
Contributor

@rawal01 can fix the conflicts

@arlakshm
Copy link
Contributor

arlakshm commented Nov 4, 2021

@rawal01 can fix the conflicts

Need to check orchagent output on all asics.
When issue 'show ip route summary' on a multi-asic DUT, we would get the
summary table for each asic.

The original code would just get the data from the last asic.
With the changes in this commit, it would accumulate the totals over all asics.
@sanmalho-git
Copy link
Contributor

@arlakshm @yxieca - we have re-based to latest github, and as part of that the original fix for ip routes calculation is now done in _parse_route_summary method in sonic.py. Could you please re-review.

Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yxieca yxieca merged commit 3b7246b into sonic-net:master Jan 14, 2022
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (#23424)

#### Why I did it
src/sonic-utilities
```
* 42b28bbf - (HEAD -> 202505, origin/202505) `vnet_route_check.py` should not report VNET routes in APP DB but not in STATE DB and ASIC DB as mismatches (sonic-net#3991) (3 hours ago) [mssonicbld]
* f36ac95a - [show][config][plugin] add processing of ModuleNotFoundError with log_warning (sonic-net#3992) (3 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants