Skip to content

[ser test] refactoring Broadcom ser test and update TD3 parameters#3991

Merged
yxieca merged 3 commits intosonic-net:masterfrom
yxieca:ser
Aug 10, 2021
Merged

[ser test] refactoring Broadcom ser test and update TD3 parameters#3991
yxieca merged 3 commits intosonic-net:masterfrom
yxieca:ser

Conversation

@yxieca
Copy link
Collaborator

@yxieca yxieca commented Aug 9, 2021

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

Broadcom SER test was failing on TD3 platform lately. It appears that SAI upgrade exposed/changed ser behavior.

How did you do it?

Refactor the ser test:

  • Add more control parameters to test script ser_injector.py
  • Categorize memory locations into: timeout, timeout_basic, slow_injection, unsupported.
  • 'thorough' mode is new the learning mode, it will identify the memory entries that doesn't support SER test, also identify the entries that will take long time when injecting error.
  • Avoid slow injection memory locations to improve test time. When avoiding these memory entries. thorough test time on TD3 reduced from 2-3 hours to 40 minutes. basic mode test is also consistently around 8-10 minutes.
  • Update TD3 parameters.

How did you verify/test it?

Run test on TD3 platform: basic: 40 times, thorough (skipping slow injections): 10 times.

yxieca added 3 commits August 9, 2021 08:01
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
- Re-organize timeout entries and unsupported entries into different
  bins so that they can be applied individually.
- Improve thorough mode to learn ASIC limits and generate output to
  help program the skip list.
- Learn memory entries that is slow in error injection and avoid them
  in regular tests.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca requested a review from sujinmkang as a code owner August 9, 2021 15:11
@yxieca yxieca requested a review from tahmed-dev August 9, 2021 15:11
@yxieca yxieca merged commit 046ad7f into sonic-net:master Aug 10, 2021
@yxieca yxieca deleted the ser branch August 10, 2021 04:39
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
…onic-net#3991)

What is the motivation for this PR?
Broadcom SER test was failing on TD3 platform lately. It appears that SAI upgrade exposed/changed ser behavior.

How did you do it?
Refactor the ser test:

Add more control parameters to test script ser_injector.py
Categorize memory locations into: timeout, timeout_basic, slow_injection, unsupported.
'thorough' mode is new the learning mode, it will identify the memory entries that doesn't support SER test, also identify the entries that will take long time when injecting error.
Avoid slow injection memory locations to improve test time. When avoiding these memory entries. thorough test time on TD3 reduced from 2-3 hours to 40 minutes. basic mode test is also consistently around 8-10 minutes.
Update TD3 parameters.
How did you verify/test it?
Run test on TD3 platform: basic: 40 times, thorough (skipping slow injections): 10 times.
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (#23424)

#### Why I did it
src/sonic-utilities
```
* 42b28bbf - (HEAD -> 202505, origin/202505) `vnet_route_check.py` should not report VNET routes in APP DB but not in STATE DB and ASIC DB as mismatches (sonic-net#3991) (3 hours ago) [mssonicbld]
* f36ac95a - [show][config][plugin] add processing of ModuleNotFoundError with log_warning (sonic-net#3992) (3 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants