[multi-asic][minigraph]: Modify minigraph templates for multi-asic platform#3025
Merged
SuvarnaMeenakshi merged 6 commits intosonic-net:masterfrom Mar 10, 2021
Merged
Conversation
to generate miningraph for multi-asic platform which will include ASIC information. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
3 tasks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
and topo_facts. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
SuvarnaMeenakshi
added a commit
that referenced
this pull request
Mar 9, 2021
…for multi-asic (#3024) What is the motivation for this PR? To support minigraph generation for multi-asic platforms. How did you do it? Multi-asic minigraph will include internal asic topology and asic metadata. To provide the internal asic information, a new topo file is added. The new topo file will hwsku specific, and will contain asic topology similar to the other topo files. A single topo file will be used to provide topology of all asics for that hwsku. In the pull request, topo files for 2 Virtual switch hwsku's is added: - topo_msft_multi_asic_vs.yml and topo_msft_four_asic_vs.yml. Made changes to topo_facts.py to parse the newly added topo files similar to the parsing logic of existing topo files. Made changes to port_alias.py to generate a list of front-end ASIC interface names and list of interfaces of each ASIC which will be used in minigraph templates. Made changes to config config_sonic_basedon_testbed to pass hwsku to topo_facts.py. Based on the hwsku, topo_facts will look for hwsku specific topo file. How did you verify/test it? No change in single-asic minigraph generation. For multi-asic platform, minigraph can be generated along with minigraph template changes added in PR #3025
Contributor
Author
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Mar 10, 2021
arlakshm
approved these changes
Mar 10, 2021
3 tasks
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#18838) #### Why I did it src/sonic-swss ``` * e1005dd6 - (HEAD -> 202305, origin/202305) [portsorch] process only updated APP_DB fields when port is already created (sonic-net#3025) (19 hours ago) [Stepan Blyshchak] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SuvarnaMeenakshi sumeenak@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Minigraph template changes to support minigraph generation for multi-asic platform.
How did you do it?
Pre-requisite: #3024
Add changes to minigraph templates to use the new data structure asic_topo_config and include asic topology.
How did you verify/test it?
With the changes in PR#3024:
Bring up four-asic VS testbed using the changes in: #2858
testbed-cli.sh -t vtestbed.csv -m veos_vtb -k ceos add-topo vms-kvm-four-asic-t1-lag password.txt
Deploy minigraph using:
./testbed-cli.sh -t vtestbed.csv -m veos_vtb deploy-mg vms-kvm-four-asic-t1-lag lab password.txt
With this, minigraph should be generated and deployed on the multi-asic VS DUT.
Check all interfaces status and BGP status.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation