[dualtor_io] Enable switchover test and add argument to enable run.#18838
Merged
bingwang-ms merged 5 commits intosonic-net:masterfrom Jun 17, 2025
Merged
[dualtor_io] Enable switchover test and add argument to enable run.#18838bingwang-ms merged 5 commits intosonic-net:masterfrom
bingwang-ms merged 5 commits intosonic-net:masterfrom
Conversation
switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hi @bingwang-ms - please help merge. |
Contributor
Author
|
test failures are not related to this change (related test should be skipped in general):
Is this a known issue? |
Contributor
Triggered a rerun. |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hi @bingwang-ms - can you help merge please? |
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]> Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…onic-net#18838) * [dualtor_io] enable switchover impact test switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests. Signed-off-by: Nikola Dancejic <[email protected]> * Adding explicit argument to enable switchover impact tests to prevent accidental run. * fix precommit * fix precommit * fix option parameters --------- Signed-off-by: Nikola Dancejic <[email protected]> Signed-off-by: Yael Tzur <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switchover impact test was disabled due to being a long test. This will enable the test, but also disable it for any PR or KVM tests.
Added an explicit argument to enable switchover impact tests to prevent accidental run.
Description of PR
Summary:
enables the switchover impact test to allow for weekly runs and adds flag to disable test for normal runs unless explicitly enabled.
Type of change
Back port request
Approach
What is the motivation for this PR?
switchover impact tests were disabled due to taking a long time. This will enable the tests again, but only if --enable_switchover_impact_test is passed as an argument.
How did you do it?
removed skip condition and added PR skip condition. Added pytest argument --enable_switchover_impact_test