Skip to content

sanity check fixes for chassis; and cache cleanup at the end of pytest session #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 5 commits into from
Feb 18, 2021
Merged

sanity check fixes for chassis; and cache cleanup at the end of pytest session #2958

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aedafd7
sanity check fixes for chassis; and cache cleanup at the end of pytes…
sanmalho-git Feb 8, 2021
42c757b
Removed the cleanup_cache fixture as there is a cleanup cache fixture…
sanmalho-git Feb 15, 2021
dffc0d7
Added cleanup_cache, but not making it autouse=True
sanmalho-git Feb 15, 2021
f4340f3
Update conftest.py
yxieca Feb 17, 2021
837a386
Adding comments to the cleanup_cache fixture
sanmalho-git Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/common/plugins/sanity_check/checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def _find_down_ports(dut, phy_interfaces, ip_interfaces):
def check_interfaces(duthosts):
def _check():
check_results = []
for dut in duthosts:
for dut in duthosts.frontend_nodes:
logger.info("Checking interfaces status on %s..." % dut.hostname)

networking_uptime = dut.get_networking_uptime().seconds
Expand Down Expand Up @@ -161,7 +161,7 @@ def _check():
def check_bgp(duthosts):
def _check():
check_results = []
for dut in duthosts:
for dut in duthosts.frontend_nodes:
def _check_bgp_status_helper():
asic_check_results = []
bgp_facts = dut.bgp_facts(asic_index='all')
Expand Down
10 changes: 10 additions & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,3 +880,13 @@ def duthost_console(localhost, creds, request):
console_password=creds['console_password'][vars['console_type']])
yield host
host.disconnect()

# Purpose of fixture cleanup_cache_for_session is to allow developers to invoke this
# fixture to cleanup testbed cache before test. This fixture is designed to be used
# during development phase to work out testbed information changes.
@pytest.fixture(scope='session')
def cleanup_cache_for_session(request):
tbname, tbinfo = get_tbinfo(request)
cache.cleanup(zone=tbname)
for a_dut in tbinfo['duts']:
cache.cleanup(zone=a_dut)