sanity check fixes for chassis; and cache cleanup at the end of pytest session#2958
Merged
yxieca merged 5 commits intosonic-net:masterfrom Feb 18, 2021
Merged
sanity check fixes for chassis; and cache cleanup at the end of pytest session#2958yxieca merged 5 commits intosonic-net:masterfrom
yxieca merged 5 commits intosonic-net:masterfrom
Conversation
3 tasks
yxieca
reviewed
Feb 11, 2021
…t session
- sanity_check:
- The BGP and Interface sanity check should be done only on frontend_nodes. In a chassis
the supervisor node has no BGP/PORT configuration.
- cache cleanup:
- If we change the inventory file and re-run pytest, the old cached data for the inventory
is used. Added fixture cleanup_cache_for_session that is called at the end of a session to
remove the facts for all the DUTs in the testbed.
… being added in test_pretest
a491150 to
42c757b
Compare
Collaborator
|
@sanmalho-git I think your cache removal code has legit use cases. I suggest: make it not auto use, so test case developer can temporarily reference it until the test case is stable. Change the clean up to before test so that the testcase don't have to fail once before cleanup. |
yxieca
reviewed
Feb 16, 2021
yxieca
approved these changes
Feb 16, 2021
Collaborator
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
sanity check:
cache cleanup:
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation