Skip to content

[everflow] Add test cases to verify multiple mirror sessions #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[everflow] Add test cases to verify multiple mirror sessions #2908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions tests/everflow/everflow_test_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ def policer_mirror_session(self, duthosts, rand_one_dut_hostname, config_method)
self.apply_policer_config(duthost, policer, config_method)

# Create a mirror session with the TEST_POLICER attached
session_info = self._mirror_session_info("TEST_POLICER_SESSION", duthost.facts["asic_type"])
session_info = self._mirror_session_info("TEST_POLICER_SESSION", duthost.facts["asic_type"], session_dst_ip="3.3.3.3")
self.apply_mirror_config(duthost, session_info, config_method, policer=policer)

yield session_info
Expand All @@ -311,6 +311,27 @@ def policer_mirror_session(self, duthosts, rand_one_dut_hostname, config_method)
self.remove_mirror_config(duthost, session_info["session_name"], config_method)
self.remove_policer_config(duthost, policer, config_method)

@pytest.fixture
def mirror_dscp_table(self, duthosts, rand_one_dut_hostname, config_method, policer_mirror_session):
duthost = duthosts[rand_one_dut_hostname]

try:
table_name = "EVERFLOW_DSCP"
table_type = "MIRROR_DSCP"
self.apply_acl_table_config(duthost, table_name, table_type, config_method)

# Add rule to match on DSCP
self.apply_acl_rule_config(duthost,
table_name,
policer_mirror_session["session_name"],
config_method,
rules=EVERFLOW_DSCP_RULES)
yield
finally:
# Clean up ACL rules and routes
self.remove_acl_rule_config(duthost, table_name, config_method)
self.remove_acl_table_config(duthost, table_name, config_method)

def apply_mirror_config(self, duthost, session_info, config_method, policer=None):
if config_method == CONFIG_MODE_CLI:
command = "config mirror_session add {} {} {} {} {} {}" \
Expand Down Expand Up @@ -569,9 +590,8 @@ def _extract_mirror_payload(self, encapsulated_packet, payload_size):
inner_frame = encapsulated_packet[-payload_size:]
return packet.Ether(inner_frame)

def _mirror_session_info(self, session_name, asic_type):
def _mirror_session_info(self, session_name, asic_type, session_dst_ip="2.2.2.2"):
session_src_ip = "1.1.1.1"
session_dst_ip = "2.2.2.2"
session_dscp = "8"
session_ttl = "1"

Expand Down
195 changes: 157 additions & 38 deletions tests/everflow/test_everflow_testbed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def dest_port_type(self, duthosts, rand_one_dut_hostname, setup_info, setup_mirr
on that. As of now cleanup is being done here.
"""
yield request.param

duthost = duthosts[rand_one_dut_hostname]

for index in range(0, min(3, len(setup_info[request.param]["dest_port"]))):
Expand Down Expand Up @@ -370,59 +370,178 @@ def test_everflow_remove_used_ecmp_next_hop(self, duthosts, rand_one_dut_hostnam
rx_port_ptf_id,
tx_port_ptf_ids
)

def test_everflow_dscp_with_policer(
self,
duthost,
setup_info,
policer_mirror_session,
dest_port_type,
partial_ptf_runner,
config_method,
tbinfo
self,
duthosts,
rand_one_dut_hostname,
setup_info,
policer_mirror_session,
dest_port_type,
partial_ptf_runner,
tbinfo,
mirror_dscp_table
):
"""Verify that we can rate-limit mirrored traffic from the MIRROR_DSCP table."""
duthost = duthosts[rand_one_dut_hostname]

# Add explicit route for the mirror session
tx_port = setup_info[dest_port_type]["dest_port"][0]
peer_ip, _ = everflow_utils.get_neighbor_info(duthost, tx_port, tbinfo)
everflow_utils.add_route(duthost, policer_mirror_session["session_prefixes"][0], peer_ip)

try:
# Add MIRROR_DSCP table for test
table_name = "EVERFLOW_DSCP"
table_type = "MIRROR_DSCP"
self.apply_acl_table_config(duthost, table_name, table_type, config_method)

# Add rule to match on DSCP
self.apply_acl_rule_config(duthost,
table_name,
policer_mirror_session["session_name"],
config_method,
rules=EVERFLOW_DSCP_RULES)
everflow_utils.add_route(duthost, policer_mirror_session["session_prefixes"][0], peer_ip)

# Run test with expected CIR/CBS in packets/sec and tolerance %
rx_port_ptf_id = setup_info[dest_port_type]["src_port_ptf_id"]
tx_port_ptf_id = setup_info[dest_port_type]["dest_port_ptf_id"][0]

partial_ptf_runner(setup_info,
policer_mirror_session,
self.acl_stage(),
self.mirror_type(),
expect_receive=True,
test_name="everflow_policer_test.EverflowPolicerTest",
src_port=rx_port_ptf_id,
dst_mirror_ports=tx_port_ptf_id,
dst_ports=tx_port_ptf_id,
meter_type="packets",
cir="100",
cbs="100",
tolerance="10")
partial_ptf_runner(
setup_info,
policer_mirror_session,
self.acl_stage(),
self.mirror_type(),
expect_receive=True,
test_name="everflow_policer_test.EverflowPolicerTest",
src_port=rx_port_ptf_id,
dst_mirror_ports=tx_port_ptf_id,
dst_ports=tx_port_ptf_id,
meter_type="packets",
cir="100",
cbs="100",
tolerance="10"
)
finally:
# Clean up ACL rules and routes
self.remove_acl_rule_config(duthost, table_name, config_method)
self.remove_acl_table_config(duthost, table_name, config_method)
everflow_utils.remove_route(duthost, policer_mirror_session["session_prefixes"][0], peer_ip)

def test_two_sessions_different_ports(
self,
duthosts,
rand_one_dut_hostname,
setup_info,
setup_mirror_session,
policer_mirror_session,
mirror_dscp_table,
dest_port_type,
ptfadapter,
partial_ptf_runner,
tbinfo
):
"""
Verify that we can setup two mirror sessions and send traffic to two different monitor ports.

We should be able to send traffic that hits rules in each table, and the traffic should
be mirrored to the correct mirror session.
"""
duthost = duthosts[rand_one_dut_hostname]

# Add a route to the standard mirror session destination IP
std_tx_port = setup_info[dest_port_type]["dest_port"][0]
std_peer_ip, _ = everflow_utils.get_neighbor_info(duthost, std_tx_port, tbinfo)
everflow_utils.add_route(duthost, setup_mirror_session["session_prefixes"][0], std_peer_ip)

# Add a route to the policer-enforced mirror session destination IP
policer_tx_port = setup_info[dest_port_type]["dest_port"][1]
policer_peer_ip, _ = everflow_utils.get_neighbor_info(duthost, policer_tx_port, tbinfo)
everflow_utils.add_route(duthost, policer_mirror_session["session_prefixes"][0], policer_peer_ip)

# Verify that mirrored traffic is sent to the standard mirror session
rx_port_ptf_id = setup_info[dest_port_type]["src_port_ptf_id"]
tx_port_ptf_id = setup_info[dest_port_type]["dest_port_ptf_id"][0]
self._run_everflow_test_scenarios(
ptfadapter,
setup_info,
setup_mirror_session,
duthost,
rx_port_ptf_id,
[tx_port_ptf_id]
)

# Verify that the DSCP traffic is sent to the policer-enforced mirror session
tx_port_ptf_id = setup_info[dest_port_type]["dest_port_ptf_id"][1]

partial_ptf_runner(
setup_info,
policer_mirror_session,
self.acl_stage(),
self.mirror_type(),
expect_receive=True,
test_name="everflow_policer_test.EverflowPolicerTest",
src_port=rx_port_ptf_id,
dst_mirror_ports=tx_port_ptf_id,
dst_ports=tx_port_ptf_id,
meter_type="packets",
cir="100",
cbs="100",
tolerance="10"
)

everflow_utils.remove_route(duthost, policer_mirror_session["session_prefixes"][0], policer_peer_ip)

def test_two_sessions_same_port(
self,
duthosts,
rand_one_dut_hostname,
setup_info,
setup_mirror_session,
policer_mirror_session,
mirror_dscp_table,
dest_port_type,
ptfadapter,
partial_ptf_runner,
tbinfo
):
"""
Verify that we can setup two mirror sessions and send traffic to the same monitor port.

We should be able to send traffic that hits rules in each table, and the traffic should
be mirrored to the correct mirror session.
"""
duthost = duthosts[rand_one_dut_hostname]

# Add a route to the standard mirror session destination IP
std_tx_port = setup_info[dest_port_type]["dest_port"][0]
std_peer_ip, _ = everflow_utils.get_neighbor_info(duthost, std_tx_port, tbinfo)
everflow_utils.add_route(duthost, setup_mirror_session["session_prefixes"][0], std_peer_ip)

# Add a route to the policer-enforced mirror session destination IP
policer_tx_port = setup_info[dest_port_type]["dest_port"][0]
policer_peer_ip, _ = everflow_utils.get_neighbor_info(duthost, policer_tx_port, tbinfo)
everflow_utils.add_route(duthost, policer_mirror_session["session_prefixes"][0], policer_peer_ip)

# Verify that mirrored traffic is sent to the standard mirror session
rx_port_ptf_id = setup_info[dest_port_type]["src_port_ptf_id"]
tx_port_ptf_id = setup_info[dest_port_type]["dest_port_ptf_id"][0]
self._run_everflow_test_scenarios(
ptfadapter,
setup_info,
setup_mirror_session,
duthost,
rx_port_ptf_id,
[tx_port_ptf_id]
)

# Verify that the DSCP traffic is sent to the policer-enforced mirror session
tx_port_ptf_id = setup_info[dest_port_type]["dest_port_ptf_id"][0]

partial_ptf_runner(
setup_info,
policer_mirror_session,
self.acl_stage(),
self.mirror_type(),
expect_receive=True,
test_name="everflow_policer_test.EverflowPolicerTest",
src_port=rx_port_ptf_id,
dst_mirror_ports=tx_port_ptf_id,
dst_ports=tx_port_ptf_id,
meter_type="packets",
cir="100",
cbs="100",
tolerance="10"
)

everflow_utils.remove_route(duthost, policer_mirror_session["session_prefixes"][0], policer_peer_ip)
Copy link
Copy Markdown
Collaborator

@yxieca yxieca Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you need to remove the route to std_peer_ip too?

Copy link
Copy Markdown
Contributor Author

@daall daall Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, good catch!


def _run_everflow_test_scenarios(self, ptfadapter, setup, mirror_session, duthost, rx_port, tx_ports, expect_recv=True):
# FIXME: In the ptf_runner version of these tests, LAGs were passed down to the tests as comma-separated strings of
# LAG member port IDs (e.g. portchannel0001 -> "2,3"). Because the DSCP test is still using ptf_runner we will preserve
Expand Down