Skip to content

[everflow] Add test cases to verify multiple mirror sessions#2908

Open
daall wants to merge 1 commit intosonic-net:masterfrom
daall:always_on_testing
Open

[everflow] Add test cases to verify multiple mirror sessions#2908
daall wants to merge 1 commit intosonic-net:masterfrom
daall:always_on_testing

Conversation

@daall
Copy link
Copy Markdown
Contributor

@daall daall commented Feb 2, 2021

Signed-off-by: Danny Allen [email protected]

Description of PR

Summary: [everflow] Add test cases to verify multiple mirror sessions
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To validate that everflow still behaves properly in the presence of multiple mirror sessions.

How did you do it?

I added two new test cases:

  1. One to verify that everything works as expected when we have two mirror sessions that point to different destinations on different ports.
  2. One to verify that everything works as expected when we have two mirror sessions that point to different destinations on the same port.

This list could be further expanded to include traffic hitting rules in multiple tables,

How did you verify/test it?

Ran tests against 201911 and master image.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@daall daall requested a review from a team February 2, 2021 22:22
tolerance="10"
)

everflow_utils.remove_route(duthost, policer_mirror_session["session_prefixes"][0], policer_peer_ip)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you need to remove the route to std_peer_ip too?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, good catch!

@yxieca
Copy link
Copy Markdown
Collaborator

yxieca commented Feb 26, 2021

@daall can you fix up this PR for merge?

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#15809)

src/sonic-utilities

* 20853a6f - (HEAD -> 202205, origin/202205) Revert "[GCU Feature Update] Cherry-pick Platform Validator PR to 202205  (sonic-net#2883)" (sonic-net#2908) (6 hours ago) [isabelmsft]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants