Dual tor failure utilities and sample tests#2845
Merged
vaibhavhd merged 5 commits intosonic-net:masterfrom Jan 27, 2021
Merged
Conversation
vaibhavhd
added
Pytest 🐍
Dual ToR Test Dev ♊
vaibhavhd
requested review from
bingwang-ms,
lolyu,
theasianpianist and
wangxin
|
This pull request introduces 2 alerts when merging d10acc2 into da434f2 - view on LGTM.com new alerts:
|
lolyu
reviewed
Jan 22, 2021
|
This pull request introduces 2 alerts when merging 22c5527 into e02de23 - view on LGTM.com new alerts:
|
Closed
theasianpianist
requested changes
Jan 26, 2021
| lo_ipv6 = ip | ||
|
|
||
| duthost.shell("ip -4 route add 0.0.0.0/0 nexthop via {}".format(lo_ipv4.ip)) | ||
| #duthost.shell("ip -6 route add ::/0 nexthop via {}".format(lo_ipv6.ip)) |
Contributor
There was a problem hiding this comment.
What's the reason for not running this line?
Contributor
Author
There was a problem hiding this comment.
Removed the comment. Right now blackholing by only removing ipv4 default. This can be modified later if needed for ipv6.
|
This pull request introduces 2 alerts when merging e61406e into 15793fb - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 7768897 into ca14e1b - view on LGTM.com new alerts:
|
theasianpianist
approved these changes
Jan 27, 2021
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#16532) src/sonic-swss * de7186c6 - (HEAD -> 202205, origin/202205) [202205][CodeQL]: Use dependencies with relevant versions in azp template. (sonic-net#2905) (13 days ago) [Nazarii Hnydyn] * 106dd9ed - [CodeQL]: Use dependencies with relevant versions in azp template. (sonic-net#2845) (3 weeks ago) [Nazarii Hnydyn]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#16642) #### Why I did it src/sonic-swss ``` * 0584d35b - (HEAD -> 202305, origin/202305) Revert "Support type7 encoded CAK key for macsec in config_db (sonic-net#2892)" (3 minutes ago) [stormliang] * 7097cf2b - Revert "[teamd]: Clean teamd process if LAG creation fails (sonic-net#2888)" (3 days ago) [stormliang] * a0eb0d07 - Support type7 encoded CAK key for macsec in config_db (sonic-net#2892) (4 days ago) [judyjoseph] * c7e5f10e - [teamd]: Clean teamd process if LAG creation fails (sonic-net#2888) (4 days ago) [Lawrence Lee] * f30b6107 - [CodeQL]: Use dependencies with relevant versions in azp template. (sonic-net#2845) (4 days ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add common utilities for dual ToR failure
Fixes # (issue) #2757
Type of change
Approach
What is the motivation for this PR?
ToR Failure utilities. This change includes fixtures to:
Some tests are added to verify functionality of these utilities.
Additionally Dual ToR failure testcase definitions are added. The implementation will be taken care in the future PRs.
How did you do it?
How did you verify/test it?
Tested utilities using sample tests on a dualtor testbed with MUX simulator running in server.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation