Skip to content

[dualtor] Implement y_cable_simulator client#2652

Merged
bingwang-ms merged 3 commits intosonic-net:masterfrom
bingwang-ms:y_cable_simulator_client
Dec 15, 2020
Merged

[dualtor] Implement y_cable_simulator client#2652
bingwang-ms merged 3 commits intosonic-net:masterfrom
bingwang-ms:y_cable_simulator_client

Conversation

@bingwang-ms
Copy link
Collaborator

Signed-off-by: bingwang bingwang@microsoft.com

Description of PR

Summary:
Fixes # (issue)
This PR is to introduce a simulator for y_cable for testing.
The simulator driver is injected into pmon container in deploy_mg for dualtor topo and hook the physical y_cable driver. The simulator interact with simulator driver running on vmhost server, and control the behavior of y_cable with open-flow.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

This commit contains the code for y_cable_simulator client.

How did you do it?

The simulator driver is injected to pmon container in 'deploy_mg' for dualtor topo and hook the physical y_cable driver. The simulator interact with simulator driver running on vmhost server, and control the behavior of y_cable with open-flow.

How did you verify/test it?

Verified on a dual-tor topo.

  1. Verify the simulator is generated and injected to both DUTs in testbeds when deploy-mg.
  2. Verify the simulator works as expected.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Only applicable to dualtor topo.

Documentation

This commit contains the code for y_cable_simulator client. The
simulator driver is injected to pmon container in 'deploy_mg' for
dualtor topo and hook the physical y_cable driver.

Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms bingwang-ms requested review from a team, lguohan and theasianpianist December 11, 2020 08:09
@wangxin wangxin requested a review from vdahiya12 December 11, 2020 08:38
@bingwang-ms bingwang-ms force-pushed the y_cable_simulator_client branch from 8967b4e to 18a6c2d Compare December 11, 2020 09:23
1. Add necessary empty line
2. Update comments and argument names
3. Update exception handling logic.

Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms bingwang-ms force-pushed the y_cable_simulator_client branch from 18a6c2d to 3cc5354 Compare December 11, 2020 09:25
@bingwang-ms
Copy link
Collaborator Author

@wangxin Thanks for your great suggestions. All updated.

@@ -0,0 +1,2 @@
mux_simulator_port: 8080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we have mux_simulator per topology?

Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms
Copy link
Collaborator Author

Thanks @wangxin . All updated.

@bingwang-ms bingwang-ms merged commit 6b3ee02 into sonic-net:master Dec 15, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
```
39cdb49c7 [202012][show] Add bgpraw to show run all (sonic-net#2639)
b3ebba2ca [202012][show] add new CLI to show tunnel route objects sonic-net#2255 (sonic-net#2659)
d08f59b9f Fixed a bug in "show vnet routes all" causing screen overrun. (sonic-net#2644) (sonic-net#2654)
a996abdb5 [202012][show] show logging CLI support for logs stored in tmpfs (sonic-net#2652)
c60f771c0 [202012][show_bfd] add local discriminator in show bfd command (sonic-net#2616)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants