[qos] Fix parameter overwrite issue#2616
Merged
neethajohn merged 1 commit intosonic-net:masterfrom Dec 3, 2020
Merged
Conversation
Signed-off-by: Neetha John <[email protected]>
vaibhavhd
approved these changes
Dec 2, 2020
Contributor
Author
|
retest vsimage please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
``` 39cdb49c7 [202012][show] Add bgpraw to show run all (sonic-net#2639) b3ebba2ca [202012][show] add new CLI to show tunnel route objects sonic-net#2255 (sonic-net#2659) d08f59b9f Fixed a bug in "show vnet routes all" causing screen overrun. (sonic-net#2644) (sonic-net#2654) a996abdb5 [202012][show] show logging CLI support for logs stored in tmpfs (sonic-net#2652) c60f771c0 [202012][show_bfd] add local discriminator in show bfd command (sonic-net#2616) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John [email protected]
Description of PR
Some tests like headroom pool size have src port ids and dst port id hardcoded in qos.yml to ensure that we can actually fill up the headroom pool. In all the tests, we initialize the 'testParams' dict with values from qos.yml and then update it with a set of basicParams that we have derived. The basicParams includes src and dst port ids which will overwrite the ones that we pulled from qos.yml
Type of change
How did you do it?
Consume the basicParams first and then update with values from qos.yml
How did you verify/test it?
Ran qos sai test on Th2 and all have passed.