Skip to content

[PFCWD]: Add helper function to set shape rate on fanout switch#257

Merged
stcheng merged 2 commits intosonic-net:masterfrom
sihuihan88:dev/sihan/shape
Sep 11, 2017
Merged

[PFCWD]: Add helper function to set shape rate on fanout switch#257
stcheng merged 2 commits intosonic-net:masterfrom
sihuihan88:dev/sihan/shape

Conversation

@sihuihan88
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Sep 7, 2017

@sihuihan88,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@stcheng
Copy link
Contributor

stcheng commented Sep 7, 2017

Could you combine the two similar playbooks using when to differentiate two different scenarios?

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to combine both two playbooks and two Jinja2 files into one file with some conditional branches to make the code cleaner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-p

@stcheng stcheng merged commit 9b45565 into sonic-net:master Sep 11, 2017
@sihuihan88 sihuihan88 deleted the dev/sihan/shape branch September 11, 2017 18:51
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
…ic-net#257)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
1.Update speed advertise command for sonic fanout switch
2.Use state db to get port speed

Summary:
Fixes # (issue)
1. Command "config interface advertised-speeds Ethernet0 None" is not supported on sonic fanout switch.
2. Port speed in APPL_DB is not reliable after autoneg operation.
### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
1. Command "config interface advertised-speeds Ethernet0 None" is not supported on sonic fanout switch.
2. Port speed in APPL_DB is not reliable after autoneg operation.
#### How did you do it?
1. Update the comand "config interface advertised-speeds Ethernet0 None" to "config interface advertised-speeds Ethernet0 all".
2. Use STATE_DB to get port speed after autoneg operation.
#### How did you verify/test it?
Run it in internal testbed
#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…nic-net#10938)


Signed-off-by: vaibhav-dahiya <[email protected]>

This PR adds the following commits are added in sonic-platform-common
ac25515 (HEAD -> 202012, origin/202012) [Credo][Ycable] changes for
synchronizing executing Telemetry API's when mux toggle is inprogress
(sonic-net#280)
fb304c1 [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing
health percent (sonic-net#279)
8bfe9c0 [Credo][Ycable] improve logging for Server Powered off/Faulty
cables (sonic-net#272)

The following commits are added in sonic-platform-daemons
6695c55 (HEAD -> 202012, origin/202012) [ycabled] fix the posting for
mux_cable_static_info per downlink when ycabled is spawned;
synchronizing executing Telemetry API (sonic-net#257)
6a315ae (HEAD -> 202012, origin/202012) [ycabled] Fix some syntax
warnings in ycabled (sonic-net#263)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Update sonic-snmpagent submodule pointer to include the following:
* Fix: if routestr does not exist, skip ([sonic-net#257](sonic-net/sonic-snmpagent#257))

Signed-off-by: dprital <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
linkmgrd:
* 3c2b546 2022-05-31 | Add default route support to `active-active` state machine (sonic-net#78) (github/202205, master, 202205) [Jing Zhang]
* 6fa892e 2022-05-27 | Degrade `LinkProberStateMachineBase` virtual function logging level (sonic-net#80) [Longxiang Lyu]
* 7b695ca 2022-05-27 | Fix mux wait timer and peer mux wait timer (sonic-net#81) [Longxiang Lyu]

platform-daemons:
* 0d90023 2022-05-31 | grpc client implementation for active-active dualtor (sonic-net#248) (github/master, github/202205, master, 202205) [vdahiya12]
* 6b8bf69 2022-05-27 | [ycabled] Fix some syntax warnings in ycabled (sonic-net#263) [vdahiya12]
* 2bcf936 2022-05-24 | [ycabled] fix the posting for mux_cable_static_info per downlink when ycabled is spawned; synchronizing executing Telemetry API (sonic-net#257) [vdahiya12]
* ce217c0 2022-04-25 | Include changes from xcvr_api in transceiver_info table (sonic-net#253) [qinchuanares]
* e0f8a35 2022-04-22 | Fix checkReplyType failed issue via recreating xcvr_table_helper on forking subprocess (sonic-net#255) [Stephen Sun]

platform-common:
* f575a40 2022-05-24 | [Credo][Ycable] changes for synchronizing executing Telemetry API's when mux toggle is inprogress (sonic-net#280) (github/202205, master, 202205) [vdahiya12]
* b043372 2022-05-11 | [sonic_ssd] Nokia-7215: "show platform ssdhealth" not showing health percent (sonic-net#279) [bill-nokia]
* d62d3d6 2022-05-04 | [CMIS]Fix low-power to high power mode transition (sonic-net#268) [Prince George]
* f918125 2022-05-02 | [syseeprom] Enable display of vendor extension TLV content (sonic-net#270) [dflynn-Nokia]
* 4e08440 2022-04-14 | [Credo][Ycable] improve logging for Server Powered off/Faulty cables (sonic-net#272) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…ic-net#2530)

* [sub module] sub module sonic-swss-common tracking 201811 branch

And include change:

Submodule src/sonic-swss-common e8caaea..a40837a:
  > [pyext] enable types in stdint.h (sonic-net#259)

Signed-off-by: Ying Xie <[email protected]>

* also include:

Submodule src/sonic-swss-common a40837a..594f4e8:
  > Optimized ProducerStateTable set/del notification processing to avoid… (sonic-net#257)

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
079f80a (HEAD -> 202111, origin/202111) Fix: if routestr does not exist, skip (sonic-net#257)
8fd0fe1 Fix: not to use blocking get_all() after keys() (sonic-net#255)
981107a Add VoQ Recirc interface (i.e., Ethernet-Rec) to interface maps for S… (sonic-net#244)

f4ecfb6 (HEAD -> 202111, origin/202111) Removing Vnet with scope default (sonic-net#2239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants