Enhance the test route flap#10938
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Dec 5, 2023
Merged
Conversation
Contributor
|
@StormLiangMS is this error log not harmful? I noticed work item 25920779 has this error log as well. |
Collaborator
Author
It is harmful, but for route flap test, since we will do the route add/withdraw, we can expect some time, it is in offloaded status, by end of this test, it will check the status, we don't need to check this kind error log in this case. |
ZhaohuiS
approved these changes
Dec 5, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 5, 2023
What is the motivation for this PR? Enhance robust of test_route_flap How did you do it? Ignore error which is expected. How did you verify/test it? Run manual test. 03:02:53 test_route_flap.test_route_flap L0384 INFO | End PASSED [100%]
Collaborator
|
Cherry-pick PR to 202305: #10948 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 5, 2023
What is the motivation for this PR? Enhance robust of test_route_flap How did you do it? Ignore error which is expected. How did you verify/test it? Run manual test. 03:02:53 test_route_flap.test_route_flap L0384 INFO | End PASSED [100%]
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
test_route_flap is flaky, sometimes errored out due to missed_frr_routes check, which is a transient log print, we should ignore it during route flap test.
Type of change
Back port request
Approach
What is the motivation for this PR?
Enhance robust of test_route_flap
How did you do it?
Ignore error which is expected.
How did you verify/test it?
Run manual test.
03:02:53 test_route_flap.test_route_flap L0384 INFO | End
PASSED [100%]
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation