[acl] ignore monit errors if test image is 201911 branch#2541
Closed
yxieca wants to merge 1 commit intosonic-net:masterfrom
Closed
[acl] ignore monit errors if test image is 201911 branch#2541yxieca wants to merge 1 commit intosonic-net:masterfrom
yxieca wants to merge 1 commit intosonic-net:masterfrom
Conversation
ACL test has a scenario where DUT is rebooted. After reboot, all services will take some time to become ready. With 201911 image, monit will start to complain critical processes are not running very early after boot up. That causes ACL test cases to fail. Signed-off-by: Ying Xie <[email protected]>
Collaborator
Author
|
The issue was caused by developer worked on the DUT, commented out the start delay in /etc/monit/monitrc and didn't restore the configuration when done. The normal untampered image won't have this issue. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atform-common][py-swsssdk] advance submodule head (sonic-net#13260) linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176) [noaOrMlnx] swss: * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (sonic-net#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (sonic-net#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (sonic-net#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (sonic-net#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (sonic-net#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (sonic-net#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (sonic-net#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (sonic-net#655) (sonic-net#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
ignore monit errors if test image is 201911 branch
Type of change
Approach
What is the motivation for this PR?
ACL test has a scenario where DUT is rebooted. After reboot, all services will take some time to become ready.
With 201911 image, monit will start to complain critical processes are not running very early after boot up. That causes ACL test cases to fail.
How did you do it?
ignore monit errors if test image is 201911 branch
How did you verify/test it?
Run acl test against dut running 201911 image. With the change, test passes:
184 passed, 184 skipped in 724.19 seconds
Signed-off-by: Ying Xie [email protected]