[action] [PR:13119] Fix qos/test_qos_dscp_mapping.py#13260
Merged
mssonicbld merged 1 commit intosonic-net:202311from Jun 13, 2024
Merged
[action] [PR:13119] Fix qos/test_qos_dscp_mapping.py#13260mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld merged 1 commit intosonic-net:202311from
Conversation
* Fix qos/test_qos_dscp_mapping.py
This test is mainly failing due to:
- Sending 10K packets at once on a ptf interface is causing nnpy
socket to be non-functional for a moment sometimes and connection
is getting timedout.
- Sometimes egress_queue_count on queue 7 is way greater than no of
packets being sent and the queue_count is not within the TOLERANCE,
this could be due to protocol packets.
- Test is not enhanced to be run on dualtor topologies (packets are
going to unexpected ToR).
- Fixtures "upstream_links" and "downstream_links" are always
referring to upper ToR, thus return values of these fixtures is not
really considering the ToR type and causing failures.
* Fix pre-commit check failures
pre-commit check is being failed with
"toggle_all_simulator_ports_to_rand_selected_tor" imported but unused
error. Added "# noqa" to suppress this failure as this import is being
used as fixture argument (similar to other tests).
8 tasks
Collaborator
Author
|
Original PR: #13119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix qos/test_qos_dscp_mapping.py failures
Fixes # aristanetworks/sonic-qual.msft#132
Type of change
Back port request
Approach
What is the motivation for this PR?
This test is mainly failing due to:
How did you do it?
Fixes involve adding right fixtures to the test methods (to consider dualtor topologies) and minor changes to address above issues.
How did you verify/test it?
With the fix test is passing well (earlier it was failing most of the times with one or other reason). Verified the fix on Arista-7260CX3-C64 202311 branch.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation