[bgpmon]Add new test case test_bgpmon by bingwang-ms · Pull Request #2521 · sonic-net/sonic-mgmt

bingwang-ms · 2020-11-12T09:55:49Z

Signed-off-by: bingwang [email protected]

Description of PR

Summary:
Fixes # (issue)
This PR implements a new test case test_bgpmon according following test plan.

Testplan:

Choose some ip address which could be reached from the DUT through default routing only
Configure BGPMON neighbor peer with the IP address from the previous item on DUT
Start capturing traffic on DUT interfaces, which are used for the default routes
The test is successfull if we found a syn tcp packet to the ip, and dst port 179 on one of the interfaces. We should capture the traffic for 2 minutes.
By default bgp connection timer is 120 seconds

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to add a new test case for bgp monitor.

How did you do it?

How did you verify/test it?

Verified on Arista-7260cx3 (t0) and vtestbed (t1)

py.test --inventory ../ansible/str,../ansible/veos --host-pattern str-7260cx3-acs-2 --module-path ../ansible --testbed vms7-t0-7260-2 --testbed_file ../ansible/testbed.csv --junit-xml=tr.xml --log-cli-level warn --collect_techsupport=False --topology=t0,any,util bgp/test_bgpmon.py
========================================================================================= test session starts =========================================================================================
collected 1 item                                                                                                                                                                                      

bgp/test_bgpmon.py::test_bgpmon PASSED                                                                                                                                                          [100%]

------------------------------------------------------------------ generated xml file: /data/Networking-acs-sonic-mgmt/tests/tr.xml -------------------------------------------------------------------
====================================================================================== 1 passed in 34.23 seconds ======================================================================================

py.test --inventory ../ansible/veos_vtb --host-pattern vlab-01 --module-path ../ansible/library/ --testbed vms-kvm-t1 --testbed_file ../ansible/vtestbed.csv --junit-xml=tr.xml --log-cli-level warn -k 'not test_restart_syncd' --topology=t1,t0,any,util bgp/test_bgpmon.py
========================================================================================= test session starts =========================================================================================
collected 1 item                                                                                                                                                                                      

bgp/test_bgpmon.py::test_bgpmon PASSED                                                                                                                                                          [100%]

-------------------------------------------------------------------------- generated xml file: /data/sonic-mgmt/tests/tr.xml --------------------------------------------------------------------------
====================================================================================== 1 passed in 34.37 seconds ======================================================================================

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Support any topo.

Documentation

Signed-off-by: bingwang <[email protected]>

lguohan · 2020-11-12T10:00:56Z

can you add this to kvmtest.sh, let's try it on kvm switch as well.

Signed-off-by: bingwang <[email protected]>

bingwang-ms · 2020-11-12T10:49:08Z

can you add this to kvmtest.sh, let's try it on kvm switch as well.

Sure. Updated.

lolyu · 2020-11-12T14:26:36Z

tests/bgp/bgpmon.j2

@@ -0,0 +1,15 @@
+{


better to name bgpmon.json.j2 and save it under tests/bgp/templates/

lolyu · 2020-11-12T14:27:08Z

tests/bgp/test_bgpmon.py

+        'local_addr': local_addr,
+        'peer_name': 'bgp_monitor'
+    }
+    bgpmon_template = Template(open(BGPMON_TEMPLATE_FILE).read())


better to use Ansible module template to do this.

We need to add those extra vars to a AnsibleHost such as ptfhost or duthost if we want to use template in Ansible module, right?

lolyu · 2020-11-12T14:39:09Z

tests/bgp/test_bgpmon.py

+@pytest.fixture
+def common_setup_teardown(duthost, ptfhost):
+    mg_facts = duthost.minigraph_facts(host=duthost.hostname)['ansible_facts']
+    peer_addr = generate_ips(1, "%s/%s" % (mg_facts['minigraph_vlan_interfaces'][0]['addr'],


What if the testbed is a t1?

pavel-shirshov

Thank you for the test case
I think the logic should be following:

Generate random ip address
Check that the ip address is routed through default routes, if not - go to item 1
Extract physical interfaces which are used as interfaces in default routes
Start capturing on the interfaces.

pavel-shirshov · 2020-11-12T17:26:40Z

tests/bgp/test_bgpmon.py

+BGPMON_TEMPLATE_FILE = 'bgp/bgpmon.j2'
+BGPMON_CONFIG_FILE = '/tmp/bgpmon.json'
+BGP_PORT = 179
+BGP_CONNECT_TIMEOUT = 120


I'd suggest to make the timeout to 121. Just to be double sure

pavel-shirshov · 2020-11-12T17:28:42Z

tests/bgp/test_bgpmon.py

+@pytest.fixture
+def common_setup_teardown(duthost, ptfhost):
+    mg_facts = duthost.minigraph_facts(host=duthost.hostname)['ansible_facts']
+    peer_addr = generate_ips(1, "%s/%s" % (mg_facts['minigraph_vlan_interfaces'][0]['addr'],


As I remember we need to generate a random ip address and check that 'ip route get ' will return default route

1.Move bgpmon.j2 to templates 2.Generate random IP address for test 3.Capture on all interfaces in default routes Signed-off-by: bingwang <[email protected]>

bingwang-ms · 2020-11-13T12:52:57Z

Updated. Please help to review @pavel-shirshov @lolyu
Thanks very much

lguohan · 2020-11-13T14:36:11Z

@pavel-shirshov , can you put the test cases under doc directory so that we can have a reference there?

pavel-shirshov · 2020-11-13T17:32:39Z

tests/bgp/test_bgpmon.py

+
+def generate_ip_through_default_route(host):
+    # Generate an IP address routed through default routes
+    ip_addrs = generate_ips(200, "200.0.0.1/24", [])


This code will iterate through the same 200.0.0.0/24 subnet.
So if the first prefix fail, other prefixes would fail too.

Updated. Thanks!

pavel-shirshov

LGTM

lguohan · 2020-11-13T20:45:27Z

@pavel-shirshov , can you provide the bgp commands to disable the nexthop tracking so that they can test it and make sure the test does not pass for negative case? i'd like to make sure the case does catch issue.

pavel-shirshov

Can you please check that your test will FAIL when you remove
ip nht resolve-via-default
from the FRR config?

The ptf hosts are placed under sonic group, and the ansible_user will be overwriten by that in ansible/group_vars/sonic/variables, which is ```admin``` in default. As a result, the login to ptf container will failed on vtestbed because of incorrect user. This commit address this issue. Signed-off-by: bingwang <[email protected]>

bingwang-ms · 2020-11-17T02:59:36Z

Can you please check that your test will FAIL when you remove
ip nht resolve-via-default
from the FRR config?

Sure. Added a new test case for verifying this. Please help to review. Thanks

Signed-off-by: bingwang <[email protected]>

yxieca · 2020-11-17T23:46:57Z

retest vsimage please

bingwang-ms · 2020-11-18T01:22:26Z

retest vsimage please

swss: * 7e274a4 2022-11-18 | [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. (sonic-net#2521) (HEAD -> 202205, github/202205) [KISHORE KUNAL] * 434e80c 2022-11-02 | Fix vs test issue: failed to remove vlan due to referenced by vlan interface (sonic-net#2504) [Stephen Sun] * 11bef87 2022-11-27 | [dual-tor] add missing SAI attribte in order to create IPNIP tunnel (sonic-net#2503) [Andriy Yurkiv] * 11aba29 2022-11-09 | [SWSS] Innovium platform specific changes in PFC Detect lua script (sonic-net#2493) [maulik_patel_marvell] * 4a165ee 2022-11-14 | Revert "[vlanmgr] Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2469)" (sonic-net#2518) [Longxiang Lyu] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>

Update sonic-swss submodule pointer to include the following: * 782a2ef Align watermark flow with port configuration ([sonic-net#2525](sonic-net/sonic-swss#2525)) * dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([sonic-net#2521](sonic-net/sonic-swss#2521)) * 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([sonic-net#2492](sonic-net/sonic-swss#2492)) Signed-off-by: dprital <[email protected]>

Add new test case test_bgpmon

27eb772

Signed-off-by: bingwang <[email protected]>

lguohan requested a review from pavel-shirshov November 12, 2020 09:59

Add test_bgpmon to kvm test.

e19e5bd

Signed-off-by: bingwang <[email protected]>

lolyu reviewed Nov 12, 2020

View reviewed changes

pavel-shirshov suggested changes Nov 12, 2020

View reviewed changes

Update after review.

acfea3e

1.Move bgpmon.j2 to templates 2.Generate random IP address for test 3.Capture on all interfaces in default routes Signed-off-by: bingwang <[email protected]>

pavel-shirshov reviewed Nov 13, 2020

View reviewed changes

pavel-shirshov approved these changes Nov 13, 2020

View reviewed changes

pavel-shirshov reviewed Nov 13, 2020

View reviewed changes

bingwang-ms force-pushed the add_bgpmon_test branch 2 times, most recently from 3329dea to 2f3e74a Compare November 17, 2020 03:41

Add a new case for verifying bgpmon when resolve-via-default is disabled

0454bdd

Signed-off-by: bingwang <[email protected]>

bingwang-ms force-pushed the add_bgpmon_test branch from 2f3e74a to 0454bdd Compare November 17, 2020 05:10

pavel-shirshov approved these changes Nov 18, 2020

View reviewed changes

bingwang-ms merged commit bbaaf00 into sonic-net:master Nov 18, 2020

Conversation

bingwang-ms commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

lguohan commented Nov 12, 2020

Uh oh!

bingwang-ms commented Nov 12, 2020

Uh oh!

lolyu Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

lolyu Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bingwang-ms Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

lolyu Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

pavel-shirshov left a comment

Choose a reason for hiding this comment

Uh oh!

pavel-shirshov Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

pavel-shirshov Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

bingwang-ms commented Nov 13, 2020

Uh oh!

lguohan commented Nov 13, 2020

Uh oh!

pavel-shirshov Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

bingwang-ms Nov 17, 2020

Choose a reason for hiding this comment

Uh oh!

pavel-shirshov left a comment

Choose a reason for hiding this comment

Uh oh!

lguohan commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavel-shirshov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bingwang-ms commented Nov 17, 2020

Uh oh!

yxieca commented Nov 17, 2020

Uh oh!

bingwang-ms commented Nov 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bingwang-ms commented Nov 12, 2020 •

edited

Loading

lolyu Nov 12, 2020 •

edited

Loading

lguohan commented Nov 13, 2020 •

edited

Loading

pavel-shirshov left a comment •

edited

Loading