[Ansible] Fix connection keyword precedence issue#2492
Merged
lolyu merged 1 commit intosonic-net:masterfrom Nov 10, 2020
Merged
[Ansible] Fix connection keyword precedence issue#2492lolyu merged 1 commit intosonic-net:masterfrom
lolyu merged 1 commit intosonic-net:masterfrom
Conversation
The `connection` keyword in playbook `check_sw_vm_interfaces.yml` has lower precedence than the `ansible_connection` variable defined in `sonic` group. Use task variable to shadow its counterparts in group variable files. Signed-off-by: Longxiang Lyu <[email protected]>
wangxin
approved these changes
Nov 10, 2020
bingwang-ms
approved these changes
Nov 10, 2020
|
If this patch should be applied to all which use "connection: switch"? |
Collaborator
Author
Hi @chiourung, the other uses of |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update sonic-swss submodule pointer to include the following: * 782a2ef Align watermark flow with port configuration ([sonic-net#2525](sonic-net/sonic-swss#2525)) * dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([sonic-net#2521](sonic-net/sonic-swss#2521)) * 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([sonic-net#2492](sonic-net/sonic-swss#2492)) Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The
connectionkeyword in playbookcheck_sw_vm_interfaces.ymlhaslower precedence than the
ansible_connectionvariable defined insonicgroup. Use task variable to shadow its counterparts in groupvariable files.
Signed-off-by: Longxiang Lyu [email protected]
Summary:
Fixes #2387
Type of change
Approach
What is the motivation for this PR?
As the description.
How did you do it?
Use task variable to override the
ansible_connectiondefined insonicgroup variable files.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation